Removed internal PSTL calls from code which was causing beta08/09 fails #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
…still had <chrono> and the omp_common.hpp file. They have been removed. Signed-off-by: todd.erdner <[email protected]>
…ed all calls to "std::endl" and replaced with " \n" Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
…er Paul's comments. Signed-off-by: todd.erdner <[email protected]>
…i_*) per suggestion from Paul. Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
… files. Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Signed-off-by: todd.erdner <[email protected]>
Fixed tf_init
…fails between beta08 and beta09. Signed-off-by: todd.erdner <[email protected]>
JoeOster
requested changes
Aug 27, 2020
JoeOster
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the internal calls into PSTL that shouldn't be there. When PSTL changed between beta08 and beta09 it was causing my samples to fail.
Fixes # (issue)
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist for Moving samples:
Links and Details can be found in the samples WG Teams Files.