Skip to content

Adding Particle Diffusion code sample to Open Source repo - 2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2020
Merged

Adding Particle Diffusion code sample to Open Source repo - 2 #41

merged 12 commits into from
Jul 21, 2020

Conversation

Alberto-Villarreal
Copy link
Contributor

Added particle-diffusion directory

@anjgola anjgola requested review from anjgola, JoeOster and mkitez July 21, 2020 04:00
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for copyright.

@@ -0,0 +1,7 @@
Copyright 2019 Intel Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyrights need update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjgola Fixed copyright. Thanks

Signed-off-by: avillarr <[email protected]>
mkitez
mkitez previously approved these changes Jul 21, 2020
anjgola
anjgola previously approved these changes Jul 21, 2020
Copy link
Contributor

@anjgola anjgola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering CI

Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to trigger CI

@JoeOster JoeOster merged commit 2fec335 into oneapi-src:master Jul 21, 2020
jimmytwei pushed a commit to jimmytwei/oneAPI-samples that referenced this pull request Mar 29, 2023
oneapi-src#42)

The CMake for the samples use a work-around for linking the SYCL
libraries, however this causes failures on Windows due to explicit
linking rather than letting the DPC++ driver handle it correctly when
passed the -fsycl flag. This commit removes the workaround as it is
believed to no longer be needed.

Signed-off-by: Larsen, Steffen <[email protected]>

Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants