Skip to content

Update Root Readme #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 24, 2020
Merged

Update Root Readme #94

merged 8 commits into from
Aug 24, 2020

Conversation

JoeOster
Copy link
Contributor

Description

Updating root readme.md

Fixes # (issue)

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

JoeOster and others added 5 commits August 11, 2020 14:47
@JoeOster
Merge pull request #1 from oneapi-src/master
fe34bc7 
ate to current
@JoeOster
Updating License file to no date in the title /*
632a7a4 
 * Copyright (c) 2020 Intel Corporation
 *
 * This program and the accompanying materials are made available under the
 * terms of the The MIT License which is available at
 * https://opensource.org/licenses/MIT.
 *
 * SPDX-License-Identifier: MIT
 */
@JoeOster
Merge pull request #2 from oneapi-src/master
7a3358d 
Update 08.19.20
@JoeOster
Update README.md
0032b0b
@akertesz
Fix FPGA entries
dadbdab
@JoeOster JoeOster requested a review from akertesz August 19, 2020 22:40
@akertesz
Copy link
Contributor

Is this an accurate representation of how this will look?
https://github.com/JoeOster/oneAPI-samples

If so, the formatting is wonky. The rightmost table column is much too narrow. Also, the titles of the sections at the bottom aren't rendering correctly. Not sure what's wrong there.

mkitez
mkitez previously approved these changes Aug 20, 2020
View reviewed changes
sravanikonda
sravanikonda previously requested changes Aug 20, 2020
View reviewed changes
@anjgola
Copy link
Contributor

anjgola commented Aug 20, 2020

Pending on changes requested by @sravanikonda

@JoeOster
Update README.md
11fdd3b 
Updates per request of sranikonda
@JoeOster
Copy link
Contributor Author

Is this an accurate representation of how this will look?
https://github.com/JoeOster/oneAPI-samples

If so, the formatting is wonky. The rightmost table column is much too narrow. Also, the titles of the sections at the bottom aren't rendering correctly. Not sure what's wrong there.

I don't see the wonky formatting
I have fixed the titles at the bottom of readme

@anjgola anjgola dismissed sravanikonda’s stale review August 24, 2020 16:52

Changes are resolved, remaining can be done in a separate PR.

@anjgola anjgola merged commit c60ee44 into oneapi-src:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjgola anjgola anjgola approved these changes

@mkitez mkitez mkitez left review comments

@sravanikonda sravanikonda sravanikonda left review comments

@akertesz akertesz Awaiting requested review from akertesz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoeOster @akertesz @anjgola @mkitez @sravanikonda @samples-ci