Merge pull request #363 from lplewa/coverity_log

bratpiorka · web-flow · commit 0bdc5ded465f · 2024-03-20T08:26:42.000+01:00
reset test global variable after use to suppress coverity false-positive.
diff --git a/test/utils/utils_log.cpp b/test/utils/utils_log.cpp
@@ -63,6 +63,7 @@ void helper_log_init(const char *var) {
     fopen_count = 0;
     fput_count = 0;
     util_log_init();
+    env_variable = NULL;
     EXPECT_EQ(fopen_count, expect_fopen_count);
     EXPECT_EQ(fput_count, expect_fput_count);
 }
@@ -97,7 +98,6 @@ TEST_F(test, parseEnv_errors) {
     expected_message = "[ERROR UMF] Cannot open output file - path too long\n";
     std::string test_env = "output:file," + std::string(300, 'x');
     helper_log_init(test_env.c_str());
-    env_variable = NULL; // reset env_variable as test_env string is freed.
 }
 
 TEST_F(test, parseEnv) {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ void helper_log_init(const char *var) {`
`63`	`63`	`fopen_count = 0;`
`64`	`64`	`fput_count = 0;`
`65`	`65`	`util_log_init();`
	`66`	`+ env_variable = NULL;`
`66`	`67`	`EXPECT_EQ(fopen_count, expect_fopen_count);`
`67`	`68`	`EXPECT_EQ(fput_count, expect_fput_count);`
`68`	`69`	`}`
`@@ -97,7 +98,6 @@ TEST_F(test, parseEnv_errors) {`
`97`	`98`	`expected_message = "[ERROR UMF] Cannot open output file - path too long\n";`
`98`	`99`	`std::string test_env = "output:file," + std::string(300, 'x');`
`99`	`100`	`helper_log_init(test_env.c_str());`
`100`		`- env_variable = NULL; // reset env_variable as test_env string is freed.`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`TEST_F(test, parseEnv) {`