Skip to content

Commit 132586a

Browse files
Add Pull Request template
1 parent 3be6f54 commit 132586a

File tree

2 files changed

+34
-1
lines changed

2 files changed

+34
-1
lines changed

.github/pull_request_template.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<!-- Provide a general summary of your changes in the Title above -->
2+
3+
### Description
4+
<!--
5+
Describe your changes in detail.
6+
For contribution process guide, look into CONTRIBUTING.md
7+
8+
If this is a relatively large or complex change:
9+
- BEFORE creating a PR, find existing or start a new discussion on Issues tab,
10+
- if the discussion is concluded, go ahead with this PR,
11+
- perhaps describe what alternatives you considered.
12+
13+
If this PR references or fixes an open issue, please link it here
14+
using "Ref. #<number>" or "Fixes: #<number>".
15+
-->
16+
17+
### Checklist
18+
<!--- Put an 'x' in the boxes that are checked -->
19+
20+
- [ ] Code compiles without errors locally
21+
- [ ] All tests pass locally
22+
- [ ] CI workflows executes properly, incl. workflows not executed per PR (e.g. Nightly)
23+
<!-- If you have more tasks to do before merging this PR, simply add them here -->
24+
25+
<!-- You can remove these entries, if they don't apply -->
26+
- [ ] New tests added, especially if they will fail without my changes
27+
- [ ] Added/extended example(s) to cover this functionality
28+
- [ ] Extended the README/documentation
29+
- [ ] All newly added source files have a license
30+
- [ ] All newly added source files are referenced in CMake files

CONTRIBUTING.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,15 @@ the proposed types, just pick a general issue with no template.
2929

3030
## Submitting Pull Requests
3131

32-
We take outside code contributions to UMF through GitHub pull requests.
32+
We take all code contributions to UMF through GitHub Pull Requests.
3333
You must first create your own fork of the project and submit your changes to a branch.
3434
You can then raise a Pull Request targeting `oneapi-src/unified-memory-framework:main`.
3535
Please try to keep commits neat and in order - please squash your commits to
3636
include only relevant ones (no "fixes after review" or similar).
3737

38+
When opening a new Pull Request, you'll be provided with a simple template
39+
to follow with the basic requirements for your changes to fulfill.
40+
3841
### Building and testing
3942

4043
Building commands can be found in the top-level Readme file - section

0 commit comments

Comments
 (0)