Skip to content

Commit 19c67d1

Browse files
Merge pull request #676 from EuphoricThinking/asserts1
fix: substitute UT_ASSERTs with asserts from GTEST part 1
2 parents fcf1f5a + 2b7141b commit 19c67d1

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

test/test_base_alloc.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ TEST_F(test, baseAllocMultiThreadedAllocMemset) {
3737

3838
for (int i = 0; i < ITERATIONS; i++) {
3939
for (int k = 0; k < ALLOCATION_SIZE; k++) {
40-
UT_ASSERTeq(*(ptrs[i].get() + k), ((i + TID) & 0xFF));
40+
ASSERT_EQ(*(ptrs[i].get() + k), ((i + TID) & 0xFF));
4141
}
4242
}
4343
};

test/test_base_alloc_linear.cpp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ TEST_F(test, baseAllocLinearAllocMoreThanPoolSize) {
2424

2525
size_t new_size = 20 * 1024 * 1024; // = 20 MB
2626
void *ptr = umf_ba_linear_alloc(pool.get(), new_size);
27-
UT_ASSERTne(ptr, NULL);
27+
ASSERT_NE(ptr, nullptr);
2828
memset(ptr, 0, new_size);
2929

3030
umf_ba_linear_free(pool.get(), ptr);
@@ -37,15 +37,14 @@ TEST_F(test, baseAllocLinearPoolContainsPointer) {
3737

3838
size_t size = 16;
3939
void *ptr = umf_ba_linear_alloc(pool.get(), size);
40-
UT_ASSERTne(ptr, NULL);
40+
ASSERT_NE(ptr, nullptr);
4141
memset(ptr, 0, size);
42-
4342
// assert pool contains pointer ptr
44-
UT_ASSERTne(umf_ba_linear_pool_contains_pointer(pool.get(), ptr), 0);
43+
ASSERT_NE(umf_ba_linear_pool_contains_pointer(pool.get(), ptr), 0);
4544

4645
// assert pool does NOT contain pointer 0x0123
47-
UT_ASSERTeq(umf_ba_linear_pool_contains_pointer(pool.get(), (void *)0x0123),
48-
0);
46+
ASSERT_EQ(umf_ba_linear_pool_contains_pointer(pool.get(), (void *)0x0123),
47+
0);
4948

5049
umf_ba_linear_free(pool.get(), ptr);
5150
}
@@ -78,14 +77,14 @@ TEST_F(test, baseAllocLinearMultiThreadedAllocMemset) {
7877
(rand() / (double)RAND_MAX));
7978
buffer[i].size = size;
8079
buffer[i].ptr = (unsigned char *)umf_ba_linear_alloc(pool, size);
81-
UT_ASSERTne(buffer[i].ptr, NULL);
80+
ASSERT_NE(buffer[i].ptr, nullptr);
8281
memset(buffer[i].ptr, (i + TID) & 0xFF, buffer[i].size);
8382
}
8483

8584
for (int i = 0; i < ITERATIONS; i++) {
86-
UT_ASSERTne(buffer[i].ptr, NULL);
85+
ASSERT_NE(buffer[i].ptr, nullptr);
8786
for (size_t k = 0; k < buffer[i].size; k++) {
88-
UT_ASSERTeq(*(buffer[i].ptr + k), (i + TID) & 0xFF);
87+
ASSERT_EQ(*(buffer[i].ptr + k), (i + TID) & 0xFF);
8988
}
9089
}
9190

test/test_proxy_lib.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ TEST_F(test, proxyLibBasic) {
3131
#else
3232
size_t size = ::malloc_usable_size(ptr);
3333
#endif
34-
UT_ASSERTeq(size, 0xDEADBEEF);
34+
ASSERT_EQ(size, 0xDEADBEEF);
3535
}

0 commit comments

Comments
 (0)