Fix: os_free(NULL) should return UMF_RESULT_SUCCESS

Fix: os_free(NULL) should return UMF_RESULT_SUCCESS
instead of UMF_RESULT_ERROR_INVALID_ARGUMENT.

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

src/provider/provider_os_memory.c

@@ -560,10 +560,14 @@ static umf_result_t os_alloc(void *provider, size_t size, size_t alignment,
 }
 
 static umf_result_t os_free(void *provider, void *ptr, size_t size) {
-    if (provider == NULL || ptr == NULL) {
+    if (provider == NULL) {
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }
 
+    if (ptr == NULL) {
+        return UMF_RESULT_SUCCESS;
+    }
+
     os_memory_provider_t *os_provider = (os_memory_provider_t *)provider;
 
     if (os_provider->fd > 0) {

test/provider_os_memory.cpp

@@ -268,13 +268,13 @@ TEST_P(umfProviderTest, free_size_0_ptr_not_null) {
     ASSERT_EQ(umf_result, UMF_RESULT_SUCCESS);
 }
 
-// other negative tests
-
 TEST_P(umfProviderTest, free_NULL) {
     umf_result_t umf_result = umfMemoryProviderFree(provider.get(), nullptr, 0);
-    ASSERT_EQ(umf_result, UMF_RESULT_ERROR_INVALID_ARGUMENT);
+    ASSERT_EQ(umf_result, UMF_RESULT_SUCCESS);
 }
 
+// other negative tests
+
 TEST_P(umfProviderTest, free_INVALID_POINTER_SIZE_GT_0) {
     umf_result_t umf_result =
         umfMemoryProviderFree(provider.get(), INVALID_PTR, page_plus_64);