Skip to content

Commit 2793e6a

Browse files
Merge pull request #967 from vinser52/svinogra_coverity
Minor fixes to clean up resources in tests
2 parents b668ae1 + 35332da commit 2793e6a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

test/pools/disjoint_pool.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,24 @@ disjoint_params_unique_handle_t poolConfig() {
2929
res = umfDisjointPoolParamsSetSlabMinSize(config,
3030
DEFAULT_DISJOINT_SLAB_MIN_SIZE);
3131
if (res != UMF_RESULT_SUCCESS) {
32+
umfDisjointPoolParamsDestroy(config);
3233
throw std::runtime_error("Failed to set slab min size");
3334
}
3435
res = umfDisjointPoolParamsSetMaxPoolableSize(
3536
config, DEFAULT_DISJOINT_MAX_POOLABLE_SIZE);
3637
if (res != UMF_RESULT_SUCCESS) {
38+
umfDisjointPoolParamsDestroy(config);
3739
throw std::runtime_error("Failed to set max poolable size");
3840
}
3941
res = umfDisjointPoolParamsSetCapacity(config, DEFAULT_DISJOINT_CAPACITY);
4042
if (res != UMF_RESULT_SUCCESS) {
43+
umfDisjointPoolParamsDestroy(config);
4144
throw std::runtime_error("Failed to set capacity");
4245
}
4346
res = umfDisjointPoolParamsSetMinBucketSize(
4447
config, DEFAULT_DISJOINT_MIN_BUCKET_SIZE);
4548
if (res != UMF_RESULT_SUCCESS) {
49+
umfDisjointPoolParamsDestroy(config);
4650
throw std::runtime_error("Failed to set min bucket size");
4751
}
4852

test/provider_os_memory.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,18 +441,22 @@ disjoint_params_unique_handle_t disjointPoolParams() {
441441
}
442442
res = umfDisjointPoolParamsSetSlabMinSize(params, 4096);
443443
if (res != UMF_RESULT_SUCCESS) {
444+
umfDisjointPoolParamsDestroy(params);
444445
throw std::runtime_error("Failed to set slab min size");
445446
}
446447
res = umfDisjointPoolParamsSetMaxPoolableSize(params, 4096);
447448
if (res != UMF_RESULT_SUCCESS) {
449+
umfDisjointPoolParamsDestroy(params);
448450
throw std::runtime_error("Failed to set max poolable size");
449451
}
450452
res = umfDisjointPoolParamsSetCapacity(params, 4);
451453
if (res != UMF_RESULT_SUCCESS) {
454+
umfDisjointPoolParamsDestroy(params);
452455
throw std::runtime_error("Failed to set capacity");
453456
}
454457
res = umfDisjointPoolParamsSetMinBucketSize(params, 64);
455458
if (res != UMF_RESULT_SUCCESS) {
459+
umfDisjointPoolParamsDestroy(params);
456460
throw std::runtime_error("Failed to set min bucket size");
457461
}
458462

0 commit comments

Comments
 (0)