Fix errors found by AddressSanitizer

Author: kswiecicki

src/pool/pool_scalable.c

@@ -168,6 +168,7 @@ static void tbb_pool_finalize(void *pool) {
     pthread_once(&tbb_is_initialized, load_tbb_symbols);
     struct tbb_memory_pool *pool_data = (struct tbb_memory_pool *)pool;
     g_tbb_ops.pool_destroy(pool_data->tbb_pool);
+    free(pool);
 }
 
 static void *tbb_malloc(void *pool, size_t size) {

test/common/provider.hpp

@@ -17,6 +17,7 @@
 
 #include "base.hpp"
 #include "cpp_helpers.hpp"
+#include "test_helpers.h"
 
 namespace umf_test {
 
@@ -68,10 +69,16 @@ struct provider_malloc : public provider_base_t {
             align = 8;
         }
 
+        // aligned_malloc returns a valid pointer despite not meeting the
+        // requirement of 'size' being multiple of 'align' even though the
+        // documentation says that it has to. AddressSanitizer returns an
+        // error because of this issue.
+        size_t aligned_size = ALIGN_UP(size, align);
+
 #ifdef _WIN32
-        *ptr = _aligned_malloc(size, align);
+        *ptr = _aligned_malloc(aligned_size, align);
 #else
-        *ptr = ::aligned_alloc(align, size);
+        *ptr = ::aligned_alloc(align, aligned_size);
 #endif
 
         return (*ptr) ? UMF_RESULT_SUCCESS

test/common/test_helpers.h

@@ -69,6 +69,8 @@ static inline void UT_OUT(const char *format, ...) {
                       (unsigned long long)(rhs)),                              \
              0)))
 
+#define ALIGN_UP(size, align) (((size) + (align)-1) & ~((align)-1))
+
 int bufferIsFilledWithChar(void *ptr, size_t size, char c);
 
 int buffersHaveSameContent(void *first, void *second, size_t size);

test/memoryPoolAPI.cpp

@@ -105,6 +105,8 @@ TEST_F(test, memoryPoolWithCustomProvider) {
     ASSERT_EQ(ret, UMF_RESULT_SUCCESS);
     ASSERT_NE(hPool, nullptr);
 
+    umfPoolDestroy(hPool);
+
     umfMemoryProviderDestroy(hProvider);
 }
 

test/pools/disjoint_pool.cpp

@@ -57,10 +57,17 @@ TEST_F(test, freeErrorPropagation) {
     static constexpr size_t size = 1024;
     void *ptr = umfPoolMalloc(pool, size);
 
+    // Check for simulated free error propagation
     freeReturn = UMF_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC;
     auto freeRet = umfPoolFree(pool, ptr);
 
     EXPECT_EQ(freeRet, freeReturn);
+
+    // Actually free the allocated memory
+    freeReturn = UMF_RESULT_SUCCESS;
+    freeRet = umfPoolFree(pool, ptr);
+
+    EXPECT_EQ(freeRet, freeReturn);
 }
 
 TEST_F(test, sharedLimits) {