Skip to content

Commit 3bbdcfe

Browse files
[CI] Move CodeQL and Trivy back into PR/Push workflow
It seems Scorecard is accepting reusable workflows now. Verified on my fork where workflows works properly and there's no change in the Score.
1 parent 5b639eb commit 3bbdcfe

File tree

3 files changed

+14
-29
lines changed

3 files changed

+14
-29
lines changed

.github/workflows/pr_push.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,15 @@ jobs:
5151
MultiNuma:
5252
needs: [Build]
5353
uses: ./.github/workflows/reusable_multi_numa.yml
54+
CodeQL:
55+
needs: [Build]
56+
permissions:
57+
contents: read
58+
security-events: write
59+
uses: ./.github/workflows/reusable_codeql.yml
60+
Trivy:
61+
needs: [Build]
62+
permissions:
63+
contents: read
64+
security-events: write
65+
uses: ./.github/workflows/reusable_trivy.yml

.github/workflows/codeql.yml renamed to .github/workflows/reusable_codeql.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,7 @@
11
# CodeQL static analysis
22
name: CodeQL
33

4-
# Due to lower score on Scorecard we're running this separately from
5-
# "PR/push" workflow. For some reason permissions weren't properly set
6-
# or recognized (by Scorecard). If Scorecard changes its behavior we can
7-
# go back to use 'workflow_call' trigger.
8-
on:
9-
push:
10-
branches-ignore:
11-
- 'dependabot/**'
12-
pull_request:
13-
14-
concurrency:
15-
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
16-
cancel-in-progress: true
4+
on: workflow_call
175

186
permissions:
197
contents: read

.github/workflows/trivy.yml renamed to .github/workflows/reusable_trivy.yml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,7 @@
11
# Runs linter for Docker files
22
name: Trivy
33

4-
# Due to lower score on Scorecard we're running this separately from
5-
# "PR/push" workflow. For some reason permissions weren't properly set
6-
# or recognized (by Scorecard). If Scorecard changes its behavior we can
7-
# use 'workflow_call' trigger.
8-
on:
9-
push:
10-
branches-ignore:
11-
- 'dependabot/**'
12-
pull_request:
13-
paths:
14-
- '.github/docker/*Dockerfile'
15-
- '.github/workflows/trivy.yml'
16-
17-
concurrency:
18-
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
19-
cancel-in-progress: true
4+
on: workflow_call
205

216
permissions:
227
contents: read

0 commit comments

Comments
 (0)