Skip to content

Commit 3bd6e46

Browse files
authored
Merge pull request #277 from lukaszstolarczuk/pr-template
Add Pull Request template
2 parents acbf9be + 0e0134e commit 3bd6e46

File tree

2 files changed

+48
-3
lines changed

2 files changed

+48
-3
lines changed

.github/pull_request_template.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<!-- Provide a short summary of your changes in the Title above -->
2+
3+
### Description
4+
<!--
5+
Describe your changes in detail.
6+
For contribution process guide, look into CONTRIBUTING.md in the main directory
7+
8+
Remember: one PR should fix or enhance one thing.
9+
Consider splitting large PR into a few smaller PRs.
10+
11+
If this is a relatively **large or complex** change:
12+
- BEFORE creating a PR, try finding an existing issue or start a new discussion,
13+
- if the discussion is concluded, go ahead with this PR,
14+
- perhaps describe what alternatives you considered.
15+
16+
If this PR references or fixes an open issue, please link it here
17+
using "Ref. #<number>" or "Fixes: #<number>".
18+
-->
19+
20+
### Checklist
21+
<!--
22+
Put an 'x' in the boxes that are checked.
23+
Before checking all the boxes please mark the PR as draft.
24+
-->
25+
26+
- [ ] Code compiles without errors locally
27+
- [ ] All tests pass locally
28+
- [ ] CI workflows execute properly
29+
<!-- If you have more tasks to do before merging this PR, simply add them here -->
30+
31+
<!-- You can remove these entries, if they don't apply -->
32+
- [ ] CI workflows, not executed per PR (e.g. Nightly), execute properly <!-- this can be checked, e.g., on your fork -->
33+
- [ ] New tests added, especially if they will fail without my changes
34+
- [ ] Added/extended example(s) to cover this functionality
35+
- [ ] Extended the README/documentation
36+
- [ ] All newly added source files have a license
37+
- [ ] All newly added source files are referenced in CMake files

CONTRIBUTING.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,19 @@ the proposed types, just pick a general issue with no template.
2929

3030
## Submitting Pull Requests
3131

32-
We take outside code contributions to UMF through GitHub pull requests.
32+
We take all code contributions to UMF through GitHub Pull Requests.
3333
You must first create your own fork of the project and submit your changes to a branch.
3434
You can then raise a Pull Request targeting `oneapi-src/unified-memory-framework:main`.
35-
Please try to keep commits neat and in order - please squash your commits to
36-
include only relevant ones (no "fixes after review" or similar).
35+
36+
When opening a new Pull Request, you'll be provided with a simple template
37+
to follow with the basic requirements for your changes to fulfill.
38+
39+
A good practices, when opening a PR, are:
40+
- one PR should fix/enhance one thing, split large PR into a few smaller PRs,
41+
- keep commits neat and in order,
42+
- squash commits to include only relevant ones (no "fixes after review" or similar),
43+
- if a commit fixes an open issue, add in the commit message line: `Fixes #<issue_no>`
44+
- if a commit only mention an open issue, add in the commit message, e.g. `Ref. #<issue_no>`
3745

3846
### Building and testing
3947

0 commit comments

Comments
 (0)