Skip allocsSpreadAcrossAllNumaNodes test...

instead of failing. Arbitrary free space can't be guaranteed during the
test runtime, hence not meeting the free space requirement should
warrant a skip not a fail.

Author: kswiecicki

test/memspaces/memspace_host_all.cpp

@@ -173,29 +173,23 @@ TEST_F(memspaceHostAllProviderTest, allocsSpreadAcrossAllNumaNodes) {
         long long numaFreeSize = 0;
         long long numaSize = numa_node_size64(id, &numaFreeSize);
         UT_ASSERTne(numaSize, -1);
-        UT_ASSERT(numaFreeSize >= (long long)(remainingSpace + size));
+        if (numaFreeSize < (long long)(remainingSpace + size)) {
+            GTEST_SKIP() << "Test skipped, not enough memory on numa node #"
+                         << id;
+        }
 
         numaCombinedFreeSize += numaFreeSize;
     }
 
     umf_result_t umf_ret = UMF_RESULT_SUCCESS;
-    // Create allocations until all the NUMA nodes until there's space only for
-    // one allocation.
+    // Create allocations until there's space only 'remainingSpace' bytes
+    // of memory left.
     std::vector<void *> allocs;
     std::unordered_set<size_t> allocNodeIds;
     while (numaCombinedFreeSize >= (long long)(remainingSpace + size)) {
         void *ptr = nullptr;
         umf_ret = umfMemoryProviderAlloc(hProvider, size, alignment, &ptr);
-        if (umf_ret != UMF_RESULT_SUCCESS) {
-            UT_ASSERTeq(umf_ret, UMF_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC);
-            const char *msg = nullptr;
-            int32_t err = 0;
-            umfMemoryProviderGetLastNativeError(hProvider, &msg, &err);
-            // In this scenario, 'UMF_OS_RESULT_ERROR_ALLOC_FAILED' indicates OOM.
-            UT_ASSERTeq(err, UMF_OS_RESULT_ERROR_ALLOC_FAILED);
-            break;
-        }
-
+        UT_ASSERTeq(umf_ret, UMF_RESULT_SUCCESS);
         UT_ASSERTne(ptr, nullptr);
         // Access the allocation, so that all the pages associated with it are
         // allocated on available NUMA nodes.