Merge pull request #102 from ldorau/Ignore_error_of_os_munmap_when_size_equals_0

Ignore error of os_munmap() when size equals 0

Author: bratpiorka

src/provider/provider_os_memory.c

@@ -337,7 +337,8 @@ static umf_result_t os_free(void *provider, void *ptr, size_t size) {
 
     errno = 0;
     int ret = os_munmap(ptr, size);
-    if (ret) {
+    // ignore error when size == 0
+    if (ret && (size > 0)) {
         os_store_last_native_error(UMF_OS_RESULT_ERROR_FREE_FAILED, errno);
         if (os_config->traces) {
             perror("memory deallocation failed");

test/provider_os_memory.cpp

@@ -257,11 +257,22 @@ TEST_P(umfProviderTest, get_name) {
     ASSERT_STREQ(name, "OS");
 }
 
+TEST_P(umfProviderTest, free_size_0_ptr_not_null) {
+    umf_result_t umf_result =
+        umfMemoryProviderFree(provider.get(), INVALID_PTR, 0);
+    ASSERT_EQ(umf_result, UMF_RESULT_SUCCESS);
+}
+
 // other negative tests
 
-TEST_P(umfProviderTest, free_INVALID_POINTER) {
+TEST_P(umfProviderTest, free_NULL) {
+    umf_result_t umf_result = umfMemoryProviderFree(provider.get(), nullptr, 0);
+    ASSERT_EQ(umf_result, UMF_RESULT_ERROR_INVALID_ARGUMENT);
+}
+
+TEST_P(umfProviderTest, free_INVALID_POINTER_SIZE_GT_0) {
     umf_result_t umf_result =
-        umfMemoryProviderFree(provider.get(), INVALID_PTR, 0);
+        umfMemoryProviderFree(provider.get(), INVALID_PTR, page_plus_64);
     ASSERT_EQ(umf_result, UMF_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC);
 
     verify_last_native_error(provider.get(), UMF_OS_RESULT_ERROR_FREE_FAILED);