Fix uninstallation random failures on Windows

PatKamin · PatKamin · commit 695706562787 · 2024-03-26T15:07:28.000+01:00
On Windows, the 'uninstall' target failed randomly. The CMake command
used for deleting files, 'cmake -E remove' seems to be not reliable.
Changing the tool used for files deletion to 'rm'.
diff --git a/cmake/cmake_uninstall.cmake.in b/cmake/cmake_uninstall.cmake.in
@@ -10,7 +10,7 @@ foreach(file ${files})
 	message(STATUS "Uninstalling $ENV{DESTDIR}${file}")
 	if(IS_SYMLINK "$ENV{DESTDIR}${file}" OR EXISTS "$ENV{DESTDIR}${file}")
 		execute_process(
-			COMMAND @CMAKE_COMMAND@ -E remove $ENV{DESTDIR}${file}
+			COMMAND rm -f $ENV{DESTDIR}${file}
 			OUTPUT_VARIABLE rm_out
 			RESULT_VARIABLE rm_retval
 		)

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ foreach(file ${files})`
`10`	`10`	`message(STATUS "Uninstalling $ENV{DESTDIR}${file}")`
`11`	`11`	`if(IS_SYMLINK "$ENV{DESTDIR}${file}" OR EXISTS "$ENV{DESTDIR}${file}")`
`12`	`12`	`execute_process(`
`13`		`- COMMAND @CMAKE_COMMAND@ -E remove $ENV{DESTDIR}${file}`
	`13`	`+ COMMAND rm -f $ENV{DESTDIR}${file}`
`14`	`14`	`OUTPUT_VARIABLE rm_out`
`15`	`15`	`RESULT_VARIABLE rm_retval`
`16`	`16`	`)`