Fix maxnode calculation in numa memory target

It should be set to the highest possible id of a node
(highest bit set in the map) + 1, and not to number
of nodes.

Author: igchor

src/memory_targets/memory_target_numa.c

@@ -41,6 +41,7 @@ static umf_result_t numa_initialize(void *params, void **memTarget) {
 
 static void numa_finalize(void *memTarget) { free(memTarget); }
 
+// sets maxnode and allocates and initializes mask based on provided memory targets
 static umf_result_t
 numa_targets_create_nodemask(struct numa_memory_target_t **targets,
                              size_t numTargets, unsigned long **mask,
@@ -61,13 +62,27 @@ numa_targets_create_nodemask(struct numa_memory_target_t **targets,
         }
     }
 
+    int lastBit = hwloc_bitmap_last(bitmap);
+    if (lastBit == -1) {
+        // no node is set
+        hwloc_bitmap_free(bitmap);
+        return UMF_RESULT_ERROR_INVALID_ARGUMENT;
+    }
+
+    *maxnode = lastBit + 1;
+
     int nrUlongs = hwloc_bitmap_nr_ulongs(bitmap);
     if (nrUlongs == -1) {
         hwloc_bitmap_free(bitmap);
         return UMF_RESULT_ERROR_UNKNOWN;
     }
 
     unsigned long *nodemask = malloc(sizeof(unsigned long) * nrUlongs);
+    if (!nodemask) {
+        hwloc_bitmap_free(bitmap);
+        return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;
+    }
+
     int ret = hwloc_bitmap_to_ulongs(bitmap, nrUlongs, nodemask);
     hwloc_bitmap_free(bitmap);
 
@@ -77,7 +92,6 @@ numa_targets_create_nodemask(struct numa_memory_target_t **targets,
     }
 
     *mask = nodemask;
-    *maxnode = nrUlongs * sizeof(unsigned long) * 8;
 
     return UMF_RESULT_SUCCESS;
 }