Add provider_free_always_fails parameter to pool jemalloc

Add the provider_free_always_fails parameter to pool jemalloc.
It should be set to true if umfMemoryProviderFree()
of the chosen provider always fails.
It is used to turn of the error messages.

This option will be needed by the future memory providers
that will not provide the free() op.

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

include/umf/pools/pool_jemalloc.h

@@ -14,8 +14,17 @@
 extern "C" {
 #endif
 
+#include <stdbool.h>
 #include <umf/memory_pool_ops.h>
 
+/// @brief Configuration of Jemalloc Pool
+typedef struct umf_jemalloc_pool_params_t {
+    /// Set to true if umfMemoryProviderFree()
+    /// of the chosen provider always fails.
+    /// It is used to turn of the error messages.
+    bool provider_free_always_fails;
+} umf_jemalloc_pool_params_t;
+
 umf_memory_pool_ops_t *umfJemallocPoolOps(void);
 
 #ifdef __cplusplus

src/pool/pool_jemalloc.c

@@ -37,6 +37,7 @@
 typedef struct jemalloc_memory_pool_t {
     umf_memory_provider_handle_t provider;
     unsigned int arena_index; // index of jemalloc arena
+    bool provider_free_always_fails;
 } jemalloc_memory_pool_t;
 
 static __TLS umf_result_t TLS_last_allocation_error;
@@ -116,7 +117,7 @@ static void arena_extent_destroy(extent_hooks_t *extent_hooks, void *addr,
 
     umf_result_t ret;
     ret = umfMemoryProviderFree(pool->provider, addr, size);
-    if (ret != UMF_RESULT_SUCCESS) {
+    if (ret != UMF_RESULT_SUCCESS && !pool->provider_free_always_fails) {
         LOG_ERR("umfMemoryProviderFree failed");
     }
 }
@@ -138,7 +139,7 @@ static bool arena_extent_dalloc(extent_hooks_t *extent_hooks, void *addr,
 
     umf_result_t ret;
     ret = umfMemoryProviderFree(pool->provider, addr, size);
-    if (ret != UMF_RESULT_SUCCESS) {
+    if (ret != UMF_RESULT_SUCCESS && !pool->provider_free_always_fails) {
         LOG_ERR("umfMemoryProviderFree failed in dalloc");
     }
 
@@ -388,7 +389,9 @@ static umf_result_t op_initialize(umf_memory_provider_handle_t provider,
                                   void *params, void **out_pool) {
     assert(provider);
     assert(out_pool);
-    (void)params; // unused
+
+    umf_jemalloc_pool_params_t *je_params =
+        (umf_jemalloc_pool_params_t *)params;
 
     extent_hooks_t *pHooks = &arena_extent_hooks;
     size_t unsigned_size = sizeof(unsigned);
@@ -402,6 +405,13 @@ static umf_result_t op_initialize(umf_memory_provider_handle_t provider,
 
     pool->provider = provider;
 
+    if (je_params) {
+        pool->provider_free_always_fails =
+            je_params->provider_free_always_fails;
+    } else {
+        pool->provider_free_always_fails = false;
+    }
+
     unsigned arena_index;
     err = je_mallctl("arenas.create", (void *)&arena_index, &unsigned_size,
                      NULL, 0);