Skip to content

Commit 7a8fda2

Browse files
Mention logger in PR template
1 parent 9755695 commit 7a8fda2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,4 @@ Before checking all the boxes please mark the PR as draft.
3535
- [ ] Extended the README/documentation
3636
- [ ] All newly added source files have a license
3737
- [ ] All newly added source files are referenced in CMake files
38+
- [ ] Logger (with debug/info/... messages) is used

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ A good practices, when opening a PR, are:
4040
- one PR should fix/enhance one thing, split large PR into a few smaller PRs,
4141
- keep commits neat and in order,
4242
- squash commits to include only relevant ones (no "fixes after review" or similar),
43-
- if a commit fixes an open issue, add in the commit message line: `Fixes #<issue_no>`
44-
- if a commit only mention an open issue, add in the commit message, e.g. `Ref. #<issue_no>`
43+
- if a commit fixes an open issue, add in the commit message line: `Fixes #<issue_no>`,
44+
- if a commit only mention an open issue, add in the commit message, e.g. `Ref. #<issue_no>`.
4545

4646
### Building and testing
4747

0 commit comments

Comments
 (0)