Add IPC test for devdax memory provider

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

test/CMakeLists.txt

@@ -344,6 +344,22 @@ if(LINUX)
             common/ipc_os_prov_common.c)
         add_umf_ipc_test(TEST ipc_os_prov_anon_fd)
         add_umf_ipc_test(TEST ipc_os_prov_shm)
+
+        build_umf_test(
+            NAME
+            ipc_devdax_prov_consumer
+            SRCS
+            ipc_devdax_prov_consumer.c
+            common/ipc_common.c
+            common/ipc_os_prov_common.c)
+        build_umf_test(
+            NAME
+            ipc_devdax_prov_producer
+            SRCS
+            ipc_devdax_prov_producer.c
+            common/ipc_common.c
+            common/ipc_os_prov_common.c)
+        add_umf_ipc_test(TEST ipc_devdax_prov)
     endif()
     if(UMF_BUILD_GPU_TESTS AND UMF_BUILD_LEVEL_ZERO_PROVIDER)
         build_umf_test(

test/common/ipc_common.c

@@ -16,7 +16,6 @@
 
 #define INET_ADDR "127.0.0.1"
 #define MSG_SIZE 1024
-#define RECV_BUFF_SIZE 1024
 
 // consumer's response message
 #define CONSUMER_MSG                                                           \
@@ -111,7 +110,6 @@ int run_consumer(int port, umf_memory_provider_ops_t *provider_ops,
                  void *provider_params, memcopy_callback_t memcopy_callback,
                  void *memcopy_ctx) {
     char consumer_message[MSG_SIZE];
-    char recv_buffer[RECV_BUFF_SIZE];
     int producer_socket = -1;
     int ret = -1;
     umf_memory_provider_handle_t provider = NULL;
@@ -138,16 +136,20 @@ int run_consumer(int port, umf_memory_provider_ops_t *provider_ops,
         goto err_umfMemoryProviderDestroy;
     }
 
+    // allocate the zeroed receive buffer
+    char *recv_buffer = calloc(1, IPC_handle_size);
+    if (!recv_buffer) {
+        fprintf(stderr, "[consumer] ERROR: out of memory\n");
+        goto err_umfMemoryProviderDestroy;
+    }
+
     producer_socket = consumer_connect(port);
     if (producer_socket < 0) {
         goto err_umfMemoryProviderDestroy;
     }
 
-    // zero the receive buffer
-    memset(recv_buffer, 0, RECV_BUFF_SIZE);
-
     // receive a producer's message
-    ssize_t recv_len = recv(producer_socket, recv_buffer, RECV_BUFF_SIZE, 0);
+    ssize_t recv_len = recv(producer_socket, recv_buffer, IPC_handle_size, 0);
     if (recv_len < 0) {
         fprintf(stderr, "[consumer] ERROR: recv() failed\n");
         goto err_close_producer_socket;

test/ipc_devdax_prov.sh

@@ -0,0 +1,34 @@
+#
+# Copyright (C) 2024 Intel Corporation
+#
+# Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+#
+
+#!/bin/bash
+
+set -e
+
+if [ "$UMF_TESTS_DEVDAX_PATH" = "" ]; then
+	echo "Test skipped, UMF_TESTS_DEVDAX_PATH is not set"
+	exit 0
+fi
+
+if [ "$UMF_TESTS_DEVDAX_SIZE" = "" ]; then
+	echo "Test skipped, UMF_TESTS_DEVDAX_SIZE is not set"
+	exit 0
+fi
+
+# port should be a number from the range <1024, 65535>
+PORT=$(( 1024 + ( $$ % ( 65535 - 1024 ))))
+
+UMF_LOG_VAL="level:debug;flush:debug;output:stderr;pid:yes"
+
+echo "Starting ipc_devdax_prov CONSUMER on port $PORT ..."
+UMF_LOG=$UMF_LOG_VAL ./umf_test-ipc_devdax_prov_consumer $PORT &
+
+echo "Waiting 1 sec ..."
+sleep 1
+
+echo "Starting ipc_devdax_prov PRODUCER on port $PORT ..."
+UMF_LOG=$UMF_LOG_VAL ./umf_test-ipc_devdax_prov_producer $PORT

test/ipc_devdax_prov_consumer.c

@@ -0,0 +1,43 @@
+/*
+ * Copyright (C) 2024 Intel Corporation
+ *
+ * Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include <umf/providers/provider_devdax_memory.h>
+
+#include "ipc_common.h"
+#include "ipc_os_prov_common.h"
+
+int main(int argc, char *argv[]) {
+    if (argc < 2) {
+        fprintf(stderr, "usage: %s <port>\n", argv[0]);
+        return -1;
+    }
+
+    int port = atoi(argv[1]);
+
+    char *path = getenv("UMF_TESTS_DEVDAX_PATH");
+    if (path == NULL || path[0] == 0) {
+        fprintf(stderr, "Test skipped, UMF_TESTS_DEVDAX_PATH is not set\n");
+        return 0;
+    }
+
+    char *size = getenv("UMF_TESTS_DEVDAX_SIZE");
+    if (size == NULL || size[0] == 0) {
+        fprintf(stderr, "Test skipped, UMF_TESTS_DEVDAX_SIZE is not set\n");
+        return 0;
+    }
+
+    umf_devdax_memory_provider_params_t devdax_params =
+        umfDevDaxMemoryProviderParamsDefault(
+            getenv("UMF_TESTS_DEVDAX_PATH"),
+            atol(getenv("UMF_TESTS_DEVDAX_SIZE")));
+
+    return run_consumer(port, umfDevDaxMemoryProviderOps(), &devdax_params,
+                        memcopy, NULL);
+}

test/ipc_devdax_prov_producer.c

@@ -0,0 +1,43 @@
+/*
+ * Copyright (C) 2024 Intel Corporation
+ *
+ * Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include <umf/providers/provider_devdax_memory.h>
+
+#include "ipc_common.h"
+#include "ipc_os_prov_common.h"
+
+int main(int argc, char *argv[]) {
+    if (argc < 2) {
+        fprintf(stderr, "usage: %s <port>\n", argv[0]);
+        return -1;
+    }
+
+    int port = atoi(argv[1]);
+
+    char *path = getenv("UMF_TESTS_DEVDAX_PATH");
+    if (path == NULL || path[0] == 0) {
+        fprintf(stderr, "Test skipped, UMF_TESTS_DEVDAX_PATH is not set\n");
+        return 0;
+    }
+
+    char *size = getenv("UMF_TESTS_DEVDAX_SIZE");
+    if (size == NULL || size[0] == 0) {
+        fprintf(stderr, "Test skipped, UMF_TESTS_DEVDAX_SIZE is not set\n");
+        return 0;
+    }
+
+    umf_devdax_memory_provider_params_t devdax_params =
+        umfDevDaxMemoryProviderParamsDefault(
+            getenv("UMF_TESTS_DEVDAX_PATH"),
+            atol(getenv("UMF_TESTS_DEVDAX_SIZE")));
+
+    return run_producer(port, umfDevDaxMemoryProviderOps(), &devdax_params,
+                        memcopy, NULL);
+}

test/test_valgrind.sh

@@ -88,6 +88,10 @@ for test in $(ls -1 umf_test-*); do
 		echo "- SKIPPED"
 		continue; # skip testing helper binaries used by the ipc_os_prov_* tests
 		;;
+	umf_test-ipc_devdax_prov_*)
+		echo "- SKIPPED"
+		continue; # skip testing helper binaries used by the ipc_devdax_prov_* tests
+		;;
 	umf_test-memspace_host_all)
 		FILTER='--gtest_filter="-*allocsSpreadAcrossAllNumaNodes"'
 		;;