Skip to content

Commit b415e78

Browse files
authored
Merge pull request #366 from lukaszstolarczuk/minor-docs-updates
Minor docs updates
2 parents 2047208 + 2609e53 commit b415e78

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

.github/docker/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ simply replace word `docker` with `podman`.
1212
To build docker image on local machine enter the root dir of the repository and execute:
1313

1414
```sh
15-
docker build -t ur:ubuntu-22.04 -f .github/docker/ubuntu-22.04.Dockerfile .
15+
docker build -t umf:ubuntu-22.04 -f .github/docker/ubuntu-22.04.Dockerfile .
1616
```
1717

1818
To set any build time variable (e.g., an optional ARG from docker recipe), add to the command (after `build`), e.g.:
@@ -33,7 +33,7 @@ One other example of using these extra build arguments are proxy settings. They
3333
To run docker container (using the previously built image) execute:
3434

3535
```sh
36-
docker run --shm-size=4G -v /your/workspace/path/:/opt/workspace:z -w /opt/workspace/ -it ur:ubuntu-22.04 /bin/bash
36+
docker run --shm-size=4G -v /your/workspace/path/:/opt/workspace:z -w /opt/workspace/ -it umf:ubuntu-22.04 /bin/bash
3737
```
3838

3939
To set (or override) any docker environment variable, add to the command (after `run`):

.github/pull_request_template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,4 @@ Before checking all the boxes please mark the PR as draft.
3535
- [ ] Extended the README/documentation
3636
- [ ] All newly added source files have a license
3737
- [ ] All newly added source files are referenced in CMake files
38+
- [ ] Logger (with debug/info/... messages) is used

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ A good practices, when opening a PR, are:
4040
- one PR should fix/enhance one thing, split large PR into a few smaller PRs,
4141
- keep commits neat and in order,
4242
- squash commits to include only relevant ones (no "fixes after review" or similar),
43-
- if a commit fixes an open issue, add in the commit message line: `Fixes #<issue_no>`
44-
- if a commit only mention an open issue, add in the commit message, e.g. `Ref. #<issue_no>`
43+
- if a commit fixes an open issue, add in the commit message line: `Fixes #<issue_no>`,
44+
- if a commit only mention an open issue, add in the commit message, e.g. `Ref. #<issue_no>`.
4545

4646
### Building and testing
4747

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ A memory provider that provides memory from L0 device.
138138
1) Linux or Windows OS
139139
2) The `UMF_BUILD_LEVEL_ZERO_PROVIDER` option turned `ON` (by default)
140140

141-
Additionally, required for tests:
141+
Additionally, required for tests:
142+
142143
3) Linux OS
143144
4) The `UMF_BUILD_GPU_TESTS` option turned `ON`
144145
5) System with Level Zero compatible GPU

0 commit comments

Comments
 (0)