Extend UMF to support IPC handles

Author: vinser52

include/umf/ipc.h

@@ -0,0 +1,56 @@
+/*
+ *
+ * Copyright (C) 2023 Intel Corporation
+ *
+ * Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ *
+ */
+
+#ifndef UMF_IPC_H
+#define UMF_IPC_H 1
+
+#include <umf/base.h>
+#include <umf/memory_pool.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+typedef struct umf_ipc_data_t *umf_ipc_handle_t;
+
+///
+/// \brief Creates an IPC handle for the specified UMF allocation.
+/// \param ptr pointer to the allocated memory.
+/// \param ipcHandle [out] returned IPC handle.
+/// \param size [out] size of IPC handle in bytes.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+enum umf_result_t umfGetIPCHandle(const void *ptr, umf_ipc_handle_t *ipcHandle,
+                                  size_t *size);
+
+///
+/// \brief Release IPC handle retrieved by umfGetIPCHandle.
+/// \param ipcHandle IPC handle.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+enum umf_result_t umfPutIPCHandle(umf_ipc_handle_t ipcHandle);
+
+///
+/// \brief Open IPC handle retrieved by umfGetIPCHandle.
+/// \param hPool [in] Pool handle where to open the the IPC handle.
+/// \param ipcHandle [in] IPC handle.
+/// \param ptr [out] pointer to the memory in the current process.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+enum umf_result_t umfOpenIPCHandle(umf_memory_pool_handle_t hPool,
+                                   umf_ipc_handle_t ipcHandle, void **ptr);
+
+///
+/// \brief Close IPC handle.
+/// \param ptr [in] pointer to the memory.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+enum umf_result_t umfCloseIPCHandle(void *ptr);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* UMF_IPC_H */

include/umf/memory_provider.h

@@ -136,6 +136,63 @@ umf_result_t umfMemoryProviderPurgeLazy(umf_memory_provider_handle_t hProvider,
 umf_result_t umfMemoryProviderPurgeForce(umf_memory_provider_handle_t hProvider,
                                          void *ptr, size_t size);
 
+/// @brief Retrieve the size of opaque data structure required to store IPC data.
+/// \param hProvider [in] handle to the memory provider.
+/// \param size [out] pointer to the size.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+enum umf_result_t
+umfMemoryProviderGetIPCHandleSize(umf_memory_provider_handle_t hProvider,
+                                  size_t *size);
+
+///
+/// @brief Retrieve an IPC memory handle for the specified allocation.
+/// \param hProvider [in] handle to the memory provider.
+/// \param ptr [in] beginning of the virtual memory range returned by
+///                 umfMemoryProviderAlloc function.
+/// \param size [in] size of the memory address range.
+/// \param ipcData [out] pointer to the preallocated opaque data structure to store IPC handle.
+/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ptr was not allocated by this provider.
+///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+umf_result_t
+umfMemoryProviderGetIPCHandle(umf_memory_provider_handle_t hProvider,
+                              const void *ptr, size_t size, void *ipcData);
+
+///
+/// @brief Release IPC handle retrieved with get_ipc_handle function.
+/// @param hProvider [in] handle to the memory provider.
+/// @param ipcData [in] pointer to the IPC opaque data structure.
+/// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ipcData was not created by this provider.
+///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+umf_result_t
+umfMemoryProviderPutIPCHandle(umf_memory_provider_handle_t hProvider,
+                              void *ipcData);
+
+///
+/// @brief Open IPC handle.
+/// @param hProvider [in] handle to the memory provider.
+/// @param ipcData [in] pointer to the IPC opaque data structure.
+/// @param ptr [out] pointer to the memory to be used in the current process.
+/// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ipcData cannot be handled by the provider.
+///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+umf_result_t
+umfMemoryProviderOpenIPCHandle(umf_memory_provider_handle_t hProvider,
+                               void *ipcData, void **ptr);
+
+///
+/// @brief Close an IPC memory handle.
+/// @param hProvider [in] handle to the memory provider.
+/// @param ptr [in] pointer returned by umfMemoryProviderOpenIPCHandle function.
+/// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+///         UMF_RESULT_ERROR_INVALID_ARGUMENT if invalid \p hProvider or \p ptr are passed.
+///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+umf_result_t
+umfMemoryProviderCloseIPCHandle(umf_memory_provider_handle_t hProvider,
+                                void *ptr);
+
 ///
 /// @brief Retrieve name of a given memory \p hProvider.
 /// @param hProvider handle to the memory provider

include/umf/memory_provider_ops.h

@@ -133,6 +133,54 @@ typedef struct umf_memory_provider_ops_t {
     ///
     umf_result_t (*purge_force)(void *provider, void *ptr, size_t size);
 
+    ///
+    /// @brief Retrieve the size of opaque data structure required to store IPC data.
+    /// @param provider pointer to the memory provider.
+    /// @param size [out] pointer to the size.
+    /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+    ///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+    umf_result_t (*get_ipc_handle_size)(void *provider, size_t *size);
+
+    ///
+    /// @brief Retrieve an IPC memory handle for the specified allocation.
+    /// @param provider pointer to the memory provider.
+    /// @param ptr beginning of the virtual memory range.
+    /// @param size size of the memory address range.
+    /// @param ipcData [out] pointer to the preallocated opaque data structure to store IPC handle.
+    /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+    ///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ptr was not allocated by this provider.
+    ///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+    umf_result_t (*get_ipc_handle)(void *provider, const void *ptr, size_t size,
+                                   void *ipcData);
+
+    ///
+    /// @brief Release IPC handle retrieved with get_ipc_handle function.
+    /// @param provider pointer to the memory provider.
+    /// @param ipcData pointer to the IPC opaque data structure.
+    /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+    ///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ipcData was not created by this provider.
+    ///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+    umf_result_t (*put_ipc_handle)(void *provider, void *ipcData);
+
+    ///
+    /// @brief Open IPC handle.
+    /// @param provider pointer to the memory provider.
+    /// @param ipcData pointer to the IPC opaque data structure.
+    /// @param ptr [out] pointer to the memory to be used in the current process.
+    /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+    ///         UMF_RESULT_ERROR_INVALID_ARGUMENT if ipcData cannot be handled by the provider.
+    ///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+    umf_result_t (*open_ipc_handle)(void *provider, void *ipcData, void **ptr);
+
+    ///
+    /// @brief Closes an IPC memory handle.
+    /// @param provider pointer to the memory provider.
+    /// @param ptr pointer to the memory retrieved with open_ipc_handle function.
+    /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
+    ///         UMF_RESULT_ERROR_INVALID_ARGUMENT if invalid \p ptr is passed.
+    ///         UMF_RESULT_ERROR_NOT_SUPPORTED if IPC functionality is not supported by this provider.
+    umf_result_t (*close_ipc_handle)(void *provider, void *ptr);
+
     ///
     /// @brief Retrieve name of a given memory \p provider.
     /// @param provider pointer to the memory provider

src/CMakeLists.txt

@@ -5,6 +5,7 @@
 include(${UMF_CMAKE_SOURCE_DIR}/cmake/helpers.cmake)
 
 set(UMF_SOURCES
+    ipc.c
     memory_pool.c
     memory_provider.c
     memory_provider_get_last_failed.c

src/ipc.c

@@ -0,0 +1,111 @@
+/*
+ *
+ * Copyright (C) 2023 Intel Corporation
+ *
+ * Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ *
+ */
+
+#include "umf/ipc.h"
+
+#include "ipc_internal.h"
+#include "memory_pool_internal.h"
+#include "provider/provider_tracking.h"
+
+#include <assert.h>
+#include <stdlib.h>
+
+enum umf_result_t
+umfGetIPCHandle(const void *ptr, umf_ipc_handle_t *umfIPCHandle, size_t *size) {
+    size_t ipcHandleSize = 0;
+    struct umf_alloc_info_t allocInfo;
+    enum umf_result_t ret =
+        umfMemoryTrackerGetAllocInfo(umfMemoryTrackerGet(), ptr, &allocInfo);
+    if (ret != UMF_RESULT_SUCCESS) {
+        return ret;
+    }
+
+    // We cannot use umfPoolGetMemoryProvider function because it returns
+    // upstream provider but we need tracking one
+    umf_memory_provider_handle_t provider = allocInfo.pool->provider;
+    assert(provider);
+
+    size_t providerIPCHandleSize;
+    ret = umfMemoryProviderGetIPCHandleSize(provider, &providerIPCHandleSize);
+    if (ret != UMF_RESULT_SUCCESS) {
+        return ret;
+    }
+
+    ipcHandleSize = sizeof(struct umf_ipc_data_t) + providerIPCHandleSize;
+    struct umf_ipc_data_t *ipcData = malloc(ipcHandleSize);
+    if (!ipcData) {
+        return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;
+    }
+
+    ret =
+        umfMemoryProviderGetIPCHandle(provider, allocInfo.base, allocInfo.size,
+                                      (void *)ipcData->providerData);
+    if (ret != UMF_RESULT_SUCCESS) {
+        free(ipcData);
+        return ret;
+    }
+
+    ipcData->size = allocInfo.size;
+    ipcData->offset = (uintptr_t)ptr - (uintptr_t)allocInfo.base;
+
+    *umfIPCHandle = ipcData;
+    *size = ipcHandleSize;
+
+    return ret;
+}
+
+enum umf_result_t umfPutIPCHandle(umf_ipc_handle_t umfIPCHandle) {
+    enum umf_result_t ret = UMF_RESULT_SUCCESS;
+
+    // TODO: Just return SUCCESS because current tracking memory provider
+    //       implementation does nothing in Put function. Tracking memory
+    //       provider relies on IPC cache and actually Put IPC handle back
+    //       to upstream memory provider when umfMemoryProviderFree is called.
+    //       To support incapsulation we should not take into account
+    //       implementation details of tracking memory provider and find the
+    //       approrpiate pool, get memory provider of that pool and call
+    //       umfMemoryProviderPutIPCHandle(hProvider,
+    //                                     umfIPCHandle->providerData);
+    free(umfIPCHandle);
+
+    return ret;
+}
+
+enum umf_result_t umfOpenIPCHandle(umf_memory_pool_handle_t hPool,
+                                   umf_ipc_handle_t umfIPCHandle, void **ptr) {
+
+    // We cannot use umfPoolGetMemoryProvider function because it returns
+    // upstream provider but we need tracking one
+    umf_memory_provider_handle_t hProvider = hPool->provider;
+    void *base = NULL;
+
+    enum umf_result_t ret = umfMemoryProviderOpenIPCHandle(
+        hProvider, (void *)umfIPCHandle->providerData, &base);
+    if (ret != UMF_RESULT_SUCCESS) {
+        return ret;
+    }
+    *ptr = (void *)((uintptr_t)base + umfIPCHandle->offset);
+
+    return UMF_RESULT_SUCCESS;
+}
+
+enum umf_result_t umfCloseIPCHandle(void *ptr) {
+    struct umf_alloc_info_t allocInfo;
+    enum umf_result_t ret =
+        umfMemoryTrackerGetAllocInfo(umfMemoryTrackerGet(), ptr, &allocInfo);
+    if (ret != UMF_RESULT_SUCCESS) {
+        return ret;
+    }
+
+    // We cannot use umfPoolGetMemoryProvider function because it returns
+    // upstream provider but we need tracking one
+    umf_memory_provider_handle_t hProvider = allocInfo.pool->provider;
+
+    return umfMemoryProviderCloseIPCHandle(hProvider, allocInfo.base);
+}

src/ipc_internal.h

@@ -0,0 +1,29 @@
+/*
+ *
+ * Copyright (C) 2023 Intel Corporation
+ *
+ * Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT.
+ * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+ *
+ */
+
+#ifndef UMF_IPC_INTERNAL_H
+#define UMF_IPC_INTERNAL_H 1
+
+#include <umf/base.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+struct umf_ipc_data_t {
+    size_t size; // size of base allocation
+    uint64_t offset;
+    char providerData[];
+};
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* UMF_IPC_INTERNAL_H */

src/memory_provider.c

@@ -118,6 +118,38 @@ umf_result_t umfMemoryProviderPurgeForce(umf_memory_provider_handle_t hProvider,
     return res;
 }
 
+enum umf_result_t
+umfMemoryProviderGetIPCHandleSize(umf_memory_provider_handle_t hProvider,
+                                  size_t *size) {
+    return hProvider->ops.get_ipc_handle_size(hProvider->provider_priv, size);
+}
+
+enum umf_result_t
+umfMemoryProviderGetIPCHandle(umf_memory_provider_handle_t hProvider,
+                              const void *ptr, size_t size, void *ipcData) {
+    return hProvider->ops.get_ipc_handle(hProvider->provider_priv, ptr, size,
+                                         ipcData);
+}
+
+enum umf_result_t
+umfMemoryProviderPutIPCHandle(umf_memory_provider_handle_t hProvider,
+                              void *ipcData) {
+    return hProvider->ops.put_ipc_handle(hProvider->provider_priv, ipcData);
+}
+
+enum umf_result_t
+umfMemoryProviderOpenIPCHandle(umf_memory_provider_handle_t hProvider,
+                               void *ipcData, void **ptr) {
+    return hProvider->ops.open_ipc_handle(hProvider->provider_priv, ipcData,
+                                          ptr);
+}
+
+enum umf_result_t
+umfMemoryProviderCloseIPCHandle(umf_memory_provider_handle_t hProvider,
+                                void *ptr) {
+    return hProvider->ops.close_ipc_handle(hProvider->provider_priv, ptr);
+}
+
 const char *umfMemoryProviderGetName(umf_memory_provider_handle_t hProvider) {
     return hProvider->ops.get_name(hProvider->provider_priv);
 }