Skip to content

Commit d64f446

Browse files
committed
Enable drd and helgrind in the valgrind jobs
Enable drd and helgrind in the valgrind jobs and remove all suppressions files. Fixes: #156 Fixes: #157 Signed-off-by: Lukasz Dorau <[email protected]>
1 parent b758327 commit d64f446

File tree

6 files changed

+5
-149
lines changed

6 files changed

+5
-149
lines changed

.github/workflows/nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
tool: ['memcheck'] # TODO: enable 'drd' and 'helgrind' when all issues are fixed
19+
tool: ['memcheck', 'drd', 'helgrind']
2020
runs-on: ubuntu-latest
2121

2222
steps:

.github/workflows/valgrind.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
tool: ['memcheck'] # TODO: enable 'drd' and 'helgrind' when all issues are fixed
14+
tool: ['memcheck', 'drd', 'helgrind']
1515
runs-on: ubuntu-latest
1616

1717
steps:

test/supp/umf_test-jemalloc_pool.supp

Lines changed: 0 additions & 7 deletions
This file was deleted.

test/supp/umf_test-memspace_host_all.supp

Lines changed: 0 additions & 21 deletions
This file was deleted.

test/supp/umf_test-provider_os_memory_config.supp

Lines changed: 0 additions & 117 deletions
This file was deleted.

test/test_valgrind.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,12 @@ for test in $(ls -1 ./umf_test-*); do
7676
echo -n "$test "
7777
LOG=${test}.log
7878
ERR=${test}.err
79-
SUP="${WORKSPACE}/test/supp/${test}.supp"
79+
SUP="${WORKSPACE}/test/supp/${TOOL}-${test}.supp"
8080
OPT_SUP=""
81-
[ -f ${SUP} ] && OPT_SUP="--suppressions=${SUP}"
81+
[ -f ${SUP} ] && OPT_SUP="--suppressions=${SUP}" && echo -n "(${TOOL}-${test}.supp) "
8282

8383
# skip tests incompatible with valgrind
84+
FILTER=""
8485
case $test in
8586
./umf_test-disjointPool) # TODO: temporarily skip failing disjointPool tests - fix it
8687
FILTER='--gtest_filter="-*pow2AlignedAlloc:*multiThreadedpow2AlignedAlloc"'

0 commit comments

Comments
 (0)