Skip to content

Commit dd41215

Browse files
committed
Fix assert in ravl_node_rank_difference_parent()
Fix assert in ravl_node_rank_difference_parent(). ravl_node_rank() do not have to be positive - it can return (-1), so the assert has to be corrected. For example: if ravl_node_rank(p) = 0 and ravl_node_rank(n) = -1, then rv = 1. Ref: #717 Signed-off-by: Lukasz Dorau <[email protected]>
1 parent 6c2c767 commit dd41215

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/ravl/ravl.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ static int ravl_node_rank_difference_parent(struct ravl_node *p,
255255
struct ravl_node *n) {
256256
int rv = ravl_node_rank(p) - ravl_node_rank(n);
257257
// assert to check integer overflow
258-
assert(rv < ravl_node_rank(p));
258+
// ravl_node_rank(x) is >= -1
259+
assert(rv <= ravl_node_rank(p) + 1);
259260
return rv;
260261
}
261262

0 commit comments

Comments
 (0)