Add missing checks and comments for umf_numa_mode_t

To be consistent with linux mbind behavior.

On windows, UMF_NUMA_MODE_BIND and UMF_NUMA_MODE_INTERLEAVE will not
be supported for now (the only mode we can support is  UMF_NUMA_MODE_PREFERRED).

Author: igchor

include/umf/providers/provider_os_memory.h

@@ -42,8 +42,9 @@ typedef enum umf_numa_mode_t {
     ///  On linux this corresponds to MPOL_DEFAULT. If this mode is specified,
     ///  nodemask must be NULL and maxnode must be 0.
     UMF_NUMA_MODE_BIND, ///< Restricts memory allocation to nodes specified in nodemask. Allocations
-                        ///  might come from any of the allowed nodes.
+    ///  might come from any of the allowed nodes. Nodemask must specify at least one node.
     UMF_NUMA_MODE_INTERLEAVE, ///< Interleaves memory allocations across the set of nodes specified in nodemask.
+                              /// Nodemask must specify at least one node.
     UMF_NUMA_MODE_PREFERRED, ///< Specifies preferred node for allocation. If allocation cannot be fulfilled,
     ///  memory will be allocated from other nodes.
     UMF_NUMA_MODE_LOCAL, ///< The memory is allocated on the node of the CPU that triggered the allocation.

src/provider/provider_os_memory.c

@@ -146,8 +146,16 @@ static hwloc_membind_policy_t translate_numa_mode(umf_numa_mode_t mode,
         }
         return HWLOC_MEMBIND_DEFAULT;
     case UMF_NUMA_MODE_BIND:
+        if (nodemaskEmpty) {
+            // nodeset must not be empty
+            return -1;
+        }
         return HWLOC_MEMBIND_BIND;
     case UMF_NUMA_MODE_INTERLEAVE:
+        if (nodemaskEmpty) {
+            // nodeset must not be empty
+            return -1;
+        }
         return HWLOC_MEMBIND_INTERLEAVE;
     case UMF_NUMA_MODE_PREFERRED:
         return HWLOC_MEMBIND_BIND;