UMF_BUILD_SHARED_LIBRARY=ON requires UMF_BUILD_OS_MEMORY_PROVIDER=ON

UMF_BUILD_SHARED_LIBRARY=ON requires UMF_BUILD_OS_MEMORY_PROVIDER=ON
on Windows because libumf.def contains the umfOsMemoryProviderOps symbol
that is unresolved on Windows if UMF_BUILD_OS_MEMORY_PROVIDER=OFF.

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

.github/workflows/basic.yml

@@ -197,12 +197,6 @@ jobs:
             pool_tracking: 'ON'
             shared_library: 'ON'
             os_provider: 'ON'
-          - os: 'windows-2022'
-            build_type: Release
-            compiler: {c: cl, cxx: cl}
-            pool_tracking: 'ON'
-            shared_library: 'ON'
-            os_provider: 'OFF'
 
     runs-on: ${{matrix.os}}
 

src/CMakeLists.txt

@@ -84,6 +84,12 @@ elseif(MACOSX)
 endif()
 
 if(UMF_BUILD_SHARED_LIBRARY)
+    if(WINDOWS AND (NOT UMF_BUILD_OS_MEMORY_PROVIDER))
+        # UMF_BUILD_SHARED_LIBRARY=ON requires UMF_BUILD_OS_MEMORY_PROVIDER=ON on Windows
+        # because libumf.def contains the umfOsMemoryProviderOps symbol
+        # that is unresolved on Windows if UMF_BUILD_OS_MEMORY_PROVIDER=OFF
+        message(FATAL_ERROR "UMF_BUILD_SHARED_LIBRARY=ON requires UMF_BUILD_OS_MEMORY_PROVIDER=ON on Windows")
+    endif()
     add_umf_library(NAME umf
                     TYPE SHARED
                     SRCS ${UMF_SOURCES}