Skip to content

Commit ee1400d

Browse files
committed
Do not assert(ptr) in umfMemoryTrackerGetAllocInfo()
Do not assert(ptr) in umfMemoryTrackerGetAllocInfo(), return UMF_RESULT_ERROR_INVALID_ARGUMENT instead. Replace LOG_WARN() with LOG_DEBUG().
1 parent 2e50454 commit ee1400d

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/provider/provider_tracking.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,19 @@ umf_memory_pool_handle_t umfMemoryTrackerGetPool(const void *ptr) {
106106

107107
umf_result_t umfMemoryTrackerGetAllocInfo(const void *ptr,
108108
umf_alloc_info_t *pAllocInfo) {
109-
assert(ptr);
110109
assert(pAllocInfo);
111110

111+
if (ptr == NULL) {
112+
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
113+
}
114+
112115
if (TRACKER == NULL) {
113-
LOG_ERR("tracker is not created");
116+
LOG_ERR("tracker does not exist");
114117
return UMF_RESULT_ERROR_NOT_SUPPORTED;
115118
}
116119

117120
if (TRACKER->map == NULL) {
118-
LOG_ERR("tracker's map is not created");
121+
LOG_ERR("tracker's map does not exist");
119122
return UMF_RESULT_ERROR_NOT_SUPPORTED;
120123
}
121124

@@ -124,9 +127,8 @@ umf_result_t umfMemoryTrackerGetAllocInfo(const void *ptr,
124127
int found = critnib_find(TRACKER->map, (uintptr_t)ptr, FIND_LE,
125128
(void *)&rkey, (void **)&rvalue);
126129
if (!found || (uintptr_t)ptr >= rkey + rvalue->size) {
127-
LOG_WARN("pointer %p not found in the "
128-
"tracker, TRACKER=%p",
129-
ptr, (void *)TRACKER);
130+
LOG_DEBUG("pointer %p not found in the tracker, TRACKER=%p", ptr,
131+
(void *)TRACKER);
130132
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
131133
}
132134

0 commit comments

Comments
 (0)