Skip to content

Commit f311aee

Browse files
committed
Enable all IPC tests
Signed-off-by: Lukasz Dorau <[email protected]>
1 parent b668ae1 commit f311aee

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

.github/workflows/reusable_dax.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ jobs:
106106
UMF_TESTS_FSDAX_PATH_2=${{env.UMF_TESTS_FSDAX_PATH_2}}
107107
ctest -C ${{matrix.build_type}} -V -R "file|fsdax"
108108
109-
# TODO: enable the provider_devdax_memory_ipc test when the IPC tests with the proxy library are fixed
110-
# see the issue: https://github.com/oneapi-src/unified-memory-framework/issues/864
111109
- name: Run the DEVDAX tests with the proxy library
112110
# proxy library is built only if libumf is a shared library
113111
if: ${{ matrix.shared_library == 'ON' }}
@@ -116,10 +114,8 @@ jobs:
116114
LD_PRELOAD=./lib/libumf_proxy.so
117115
UMF_TESTS_DEVDAX_PATH="/dev/dax${{env.DEVDAX_NAMESPACE}}"
118116
UMF_TESTS_DEVDAX_SIZE="$(ndctl list --namespace=namespace${{env.DEVDAX_NAMESPACE}} | grep size | cut -d':' -f2 | cut -d',' -f1)"
119-
ctest -C ${{matrix.build_type}} -V -R devdax -E provider_devdax_memory_ipc
117+
ctest -C ${{matrix.build_type}} -V -R devdax
120118
121-
# TODO: enable the provider_file_memory_ipc test when the IPC tests with the proxy library are fixed
122-
# see the issue: https://github.com/oneapi-src/unified-memory-framework/issues/864
123119
- name: Run the FSDAX tests with the proxy library
124120
# proxy library is built only if libumf is a shared library
125121
if: ${{ matrix.shared_library == 'ON' }}
@@ -128,7 +124,7 @@ jobs:
128124
LD_PRELOAD=./lib/libumf_proxy.so
129125
UMF_TESTS_FSDAX_PATH=${{env.UMF_TESTS_FSDAX_PATH}}
130126
UMF_TESTS_FSDAX_PATH_2=${{env.UMF_TESTS_FSDAX_PATH_2}}
131-
ctest -C ${{matrix.build_type}} -V -R "file|fsdax" -E provider_file_memory_ipc
127+
ctest -C ${{matrix.build_type}} -V -R "file|fsdax"
132128
133129
- name: Check coverage
134130
if: ${{ matrix.build_type == 'Debug' }}

.github/workflows/reusable_proxy_lib.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,9 @@ jobs:
5959
- name: Build UMF
6060
run: cmake --build ${{env.BUILD_DIR}} -j $(nproc)
6161

62-
# TODO enable the provider_file_memory_ipc test when the IPC tests with the proxy library are fixed
63-
# see the issue: https://github.com/oneapi-src/unified-memory-framework/issues/864
6462
- name: Run "ctest --output-on-failure" with proxy library
6563
working-directory: ${{env.BUILD_DIR}}
66-
run: LD_PRELOAD=./lib/libumf_proxy.so ctest --output-on-failure -E provider_file_memory_ipc
64+
run: LD_PRELOAD=./lib/libumf_proxy.so ctest --output-on-failure
6765

6866
- name: Run "./test/umf_test-memoryPool" with proxy library
6967
working-directory: ${{env.BUILD_DIR}}
@@ -77,14 +75,12 @@ jobs:
7775
working-directory: ${{env.BUILD_DIR}}
7876
run: UMF_PROXY="page.disposition=shared-shm" LD_PRELOAD=./lib/libumf_proxy.so /usr/bin/date
7977

80-
# TODO enable the provider_file_memory_ipc test when the IPC tests with the proxy library are fixed
81-
# see the issue: https://github.com/oneapi-src/unified-memory-framework/issues/864
8278
- name: Run "ctest --output-on-failure" with proxy library and size.threshold=128
8379
working-directory: ${{env.BUILD_DIR}}
8480
run: >
8581
UMF_PROXY="page.disposition=shared-shm;size.threshold=128"
8682
LD_PRELOAD=./lib/libumf_proxy.so
87-
ctest --output-on-failure -E provider_file_memory_ipc
83+
ctest --output-on-failure
8884
8985
- name: Check coverage
9086
if: ${{ matrix.build_type == 'Debug' }}

0 commit comments

Comments
 (0)