Skip to content

Commit f6443e5

Browse files
committed
Use utils_getpid() and utils_gettid() in util_log_internal()
Signed-off-by: Lukasz Dorau <[email protected]>
1 parent 0ae2bb5 commit f6443e5

File tree

2 files changed

+12
-18
lines changed

2 files changed

+12
-18
lines changed

src/utils/utils_log.c

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,8 @@ static void util_log_internal(util_log_level_t level, int perror,
7272
return;
7373
}
7474

75-
#if defined(_WIN32)
76-
DWORD pid = GetCurrentProcessId();
77-
DWORD tid = GetCurrentThreadId();
78-
#elif defined(__APPLE__)
79-
pid_t pid = getpid();
80-
uint64_t tid64;
81-
pthread_threadid_np(NULL, &tid64);
82-
pid_t tid = (pid_t)tid64;
83-
#else
84-
pid_t pid = getpid();
85-
pid_t tid = gettid();
86-
#endif
75+
pid_t pid = utils_getpid();
76+
pid_t tid = utils_gettid();
8777

8878
char buffer[LOG_MAX];
8979
char *b_pos = buffer;

test/CMakeLists.txt

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,18 @@ add_umf_test(NAME memoryProvider SRCS memoryProviderAPI.cpp)
9393
if(UMF_BUILD_SHARED_LIBRARY)
9494
# if build as shared library, utils symbols won't be visible in tests
9595
set(UMF_UTILS_FOR_TEST umf_utils)
96+
if(LINUX OR MACOSX)
97+
set(UMF_UTILS_SOURCES
98+
../src/utils/utils_common.c ../src/utils/utils_posix_common.c
99+
../src/utils/utils_posix_concurrency.c)
100+
elseif(WINDOWS)
101+
set(UMF_UTILS_SOURCES
102+
../src/utils/utils_common.c ../src/utils/utils_windows_common.c
103+
../src/utils/utils_windows_concurrency.c)
104+
endif()
96105
endif()
97106

98-
if(UMF_BUILD_SHARED_LIBRARY)
99-
add_umf_test(NAME logger SRCS utils/utils_log.cpp
100-
../src/utils/utils_common.c)
101-
else()
102-
add_umf_test(NAME logger SRCS utils/utils_log.cpp)
103-
endif()
107+
add_umf_test(NAME logger SRCS utils/utils_log.cpp ${UMF_UTILS_SOURCES})
104108

105109
add_umf_test(
106110
NAME utils_common

0 commit comments

Comments
 (0)