Enable drd and helgrind in the Nightly CI job

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

.github/workflows/nightly.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-          tool: ['memcheck'] # TODO: enable 'drd' and 'helgrind' when all issues are fixed
+          tool: ['memcheck', 'drd', 'helgrind']
     runs-on: ubuntu-latest
 
     steps:

test/supp/drd-umf_test-jemalloc_pool.supp

@@ -0,0 +1,6 @@
+{
+   Conflicting Access in libjemalloc.so*
+   drd:ConflictingAccess
+   obj:/usr/lib/x86_64-linux-gnu/libjemalloc.so*
+   ...
+}

test/supp/drd-umf_test-scalable_pool.supp

@@ -0,0 +1,35 @@
+{
+   Conflicting Access in libtbbmalloc.so*
+   drd:ConflictingAccess
+   obj:*libtbbmalloc.so*
+   ...
+}
+
+{
+   Conflicting Access in memset in pow2AlignedAllocHelper
+   drd:ConflictingAccess
+   fun:memset
+   fun:*pow2AlignedAllocHelper*
+   ...
+}
+
+{
+   ConflictingAccess in tbb_realloc in multiThreadedReallocFree test
+   drd:ConflictingAccess
+   fun:memmove
+   obj:*libtbbmalloc.so*
+   fun:tbb_realloc
+   fun:umfPoolRealloc
+   fun:*umfPoolTest_multiThreadedReallocFree*
+   ...
+}
+
+{
+   ConflictingAccess in memset in multiThreadedCallocFree test
+   drd:ConflictingAccess
+   fun:memset
+   fun:tbb_calloc
+   fun:umfPoolCalloc
+   fun:*umfPoolTest_multiThreadedCallocFree*
+   ...
+}

test/supp/helgrind-umf_test-disjointPool.supp

@@ -0,0 +1,15 @@
+{
+   pthread_mutex_lock with a pthread_rwlock_t* argument
+   Helgrind:Misc
+   obj:*vgpreload_helgrind-amd64-linux.so
+   fun:*gthread_mutex_lock*pthread_mutex_t
+   ...
+}
+
+{
+   pthread_mutex_unlock with a pthread_rwlock_t* argument
+   Helgrind:Misc
+   obj:*vgpreload_helgrind-amd64-linux.so
+   fun:*gthread_mutex_unlock*pthread_mutex_t
+   ...
+}

test/supp/helgrind-umf_test-jemalloc_pool.supp

@@ -0,0 +1,6 @@
+{
+   Race in libjemalloc.so*
+   Helgrind:Race
+   obj:/usr/lib/x86_64-linux-gnu/libjemalloc.so*
+   ...
+}

test/supp/helgrind-umf_test-scalable_pool.supp

@@ -0,0 +1,35 @@
+{
+   Race in libtbbmalloc.so*
+   Helgrind:Race
+   obj:/usr/lib/x86_64-linux-gnu/libtbbmalloc.so*
+   ...
+}
+
+{
+   Race Access in memset in pow2AlignedAllocHelper
+   Helgrind:Race
+   fun:memset
+   fun:*pow2AlignedAllocHelper*
+   ...
+}
+
+{
+   Race in tbb_realloc in multiThreadedReallocFree test
+   Helgrind:Race
+   fun:memmove
+   obj:*libtbbmalloc.so*
+   fun:tbb_realloc
+   fun:umfPoolRealloc
+   fun:*umfPoolTest_multiThreadedReallocFree*
+   ...
+}
+
+{
+   Race in memset in multiThreadedCallocFree test
+   Helgrind:Race
+   fun:memset
+   fun:tbb_calloc
+   fun:umfPoolCalloc
+   fun:*umfPoolTest_multiThreadedCallocFree*
+   ...
+}

test/supp/umf_test-provider_os_memory_config.supp renamed to test/supp/memcheck-umf_test-provider_os_memory_config.supp

@@ -71,15 +71,15 @@ echo "Running: \"valgrind $OPTION\" for the following tests:"
 FAIL=0
 rm -f umf_test-*.log umf_test-*.err
 
-for test in $(ls -1 ./umf_test-*); do
+for test in $(ls -1 umf_test-*); do
 	[ ! -x $test ] && continue
 	echo -n "$test "
 	LOG=${test}.log
 	ERR=${test}.err
-	SUP="${WORKSPACE}/test/supp/${test}.supp"
+	SUP="${WORKSPACE}/test/supp/${TOOL}-${test}.supp"
 	OPT_SUP=""
-	[ -f ${SUP} ] && OPT_SUP="--suppressions=${SUP}"
-	HWLOC_CPUID_PATH=./cpuid valgrind $OPTION $OPT_SUP --gen-suppressions=all $test >$LOG 2>&1 || echo -n "(valgrind failed) "
+	[ -f ${SUP} ] && OPT_SUP="--suppressions=${SUP}" && echo -n "(${TOOL}-${test}.supp) "
+	HWLOC_CPUID_PATH=./cpuid valgrind $OPTION $OPT_SUP --gen-suppressions=all ./$test >$LOG 2>&1 || echo -n "(valgrind failed) "
 	# grep for "ERROR SUMMARY" with errors (there can be many lines with "ERROR SUMMARY")
 	grep -e "ERROR SUMMARY:" $LOG | grep -v -e "ERROR SUMMARY: 0 errors from 0 contexts" > $ERR || true
 	if [ $(cat $ERR | wc -l) -eq 0 ]; then