Always install examples #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Mar 21, 2024
We only install source files, not compiled binaries. So, we don't need to properly build them before we install them. They are just to be read as part of the documentation.
lukaszstolarczuk
force-pushed
the
always-install-examples
branch
from
f1e0876 to
62fa283
Compare
PatKamin
approved these changes
Mar 22, 2024
bratpiorka
approved these changes
Mar 22, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Examples are installed in system as a documentation, hence only the source files are installed, not binaries... so we can install examples all the time, not under an
if.A minor cleanup in the installation area of CMake is done as well (in a sep. commit).
Checklist