Skip to content

Commit 16d4f24

Browse files
callumfarefabiomestre
authored andcommitted
[SYCL][UR] Bump UR version and add missing values to pi2ur (#10049)
Includes a large number of missing `pi_result` mappings, so previously reported errors should no longer map to just `PI_ERROR_UNKNOWN`. NFCI for the adapters.
1 parent 23999fc commit 16d4f24

File tree

3 files changed

+22
-13
lines changed

3 files changed

+22
-13
lines changed

device.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -968,7 +968,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
968968

969969
return ReturnValue(ILVersion.data(), ILVersion.size());
970970
}
971-
case UR_EXT_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP: {
971+
case UR_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP: {
972972
// Maximum number of 32-bit registers available to a thread block.
973973
// Note: This number is shared by all thread blocks simultaneously resident
974974
// on a multiprocessor.

kernel.cpp

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetNativeHandle(
186186
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
187187
}
188188

189-
UR_APIEXPORT ur_result_t UR_APICALL
190-
urKernelSetArgValue(ur_kernel_handle_t hKernel, uint32_t argIndex,
191-
size_t argSize, const void *pArgValue) {
189+
UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgValue(
190+
ur_kernel_handle_t hKernel, uint32_t argIndex, size_t argSize,
191+
const ur_kernel_arg_value_properties_t *pProperties,
192+
const void *pArgValue) {
193+
std::ignore = pProperties;
192194
UR_ASSERT(hKernel, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
193195
UR_ASSERT(argSize, UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE);
194196

@@ -289,8 +291,11 @@ urKernelGetSubGroupInfo(ur_kernel_handle_t hKernel, ur_device_handle_t hDevice,
289291
return UR_RESULT_ERROR_INVALID_ENUMERATION;
290292
}
291293

292-
UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgPointer(
293-
ur_kernel_handle_t hKernel, uint32_t argIndex, const void *pArgValue) {
294+
UR_APIEXPORT ur_result_t UR_APICALL
295+
urKernelSetArgPointer(ur_kernel_handle_t hKernel, uint32_t argIndex,
296+
const ur_kernel_arg_pointer_properties_t *pProperties,
297+
const void *pArgValue) {
298+
std::ignore = pProperties;
294299
hKernel->setKernelArg(argIndex, sizeof(pArgValue), pArgValue);
295300
return UR_RESULT_SUCCESS;
296301
}
@@ -339,10 +344,12 @@ urKernelSetArgMemObj(ur_kernel_handle_t hKernel, uint32_t argIndex,
339344
}
340345

341346
// A NOP for the CUDA backend
342-
UR_APIEXPORT ur_result_t UR_APICALL
343-
urKernelSetExecInfo(ur_kernel_handle_t hKernel, ur_kernel_exec_info_t propName,
344-
size_t propSize, const void *pPropValue) {
347+
UR_APIEXPORT ur_result_t UR_APICALL urKernelSetExecInfo(
348+
ur_kernel_handle_t hKernel, ur_kernel_exec_info_t propName, size_t propSize,
349+
const ur_kernel_exec_info_properties_t *pProperties,
350+
const void *pPropValue) {
345351
std::ignore = propSize;
352+
std::ignore = pProperties;
346353
UR_ASSERT(hKernel, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
347354
UR_ASSERT(pPropValue, UR_RESULT_ERROR_INVALID_NULL_POINTER);
348355
switch (propName) {
@@ -370,8 +377,10 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelCreateWithNativeHandle(
370377

371378
UR_APIEXPORT ur_result_t UR_APICALL
372379
urKernelSetArgSampler(ur_kernel_handle_t hKernel, uint32_t argIndex,
380+
const ur_kernel_arg_sampler_properties_t *pProperties,
373381
ur_sampler_handle_t hArgValue) {
374382
UR_ASSERT(hKernel, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
383+
std::ignore = pProperties;
375384

376385
ur_result_t Result = UR_RESULT_SUCCESS;
377386
try {

queue.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ urQueueCreate(ur_context_handle_t hContext, ur_device_handle_t hDevice,
134134
bool IsOutOfOrder = false;
135135
if (pProps && pProps->stype == UR_STRUCTURE_TYPE_QUEUE_PROPERTIES) {
136136
URFlags = pProps->flags;
137-
if (URFlags == __SYCL_UR_CUDA_USE_DEFAULT_STREAM) {
137+
if (URFlags == UR_QUEUE_FLAG_USE_DEFAULT_STREAM) {
138138
Flags = CU_STREAM_DEFAULT;
139-
} else if (URFlags == __SYCL_UR_CUDA_SYNC_WITH_DEFAULT) {
139+
} else if (URFlags == UR_QUEUE_FLAG_SYNC_WITH_DEFAULT_STREAM) {
140140
Flags = 0;
141141
}
142142

@@ -261,9 +261,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urQueueCreateWithNativeHandle(
261261

262262
ur_queue_flags_t Flags = 0;
263263
if (CuFlags == CU_STREAM_DEFAULT)
264-
Flags = __SYCL_UR_CUDA_USE_DEFAULT_STREAM;
264+
Flags = UR_QUEUE_FLAG_USE_DEFAULT_STREAM;
265265
else if (CuFlags == CU_STREAM_NON_BLOCKING)
266-
Flags = __SYCL_UR_CUDA_SYNC_WITH_DEFAULT;
266+
Flags = UR_QUEUE_FLAG_SYNC_WITH_DEFAULT_STREAM;
267267
else
268268
sycl::detail::ur::die("Unknown cuda stream");
269269

0 commit comments

Comments
 (0)