Skip to content

Commit 70e4cdc

Browse files
authored
Merge pull request #2034 from igchor/benchmark_tweaks
[Benchmarks] minor tweaks
2 parents b09a969 + 413d458 commit 70e4cdc

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

scripts/benchmarks/benches/compute.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def run(self, env_vars) -> Result:
8282

8383
result = self.run_bench(command, env_vars)
8484
(label, mean) = self.parse_output(result)
85-
return Result(label=label, value=mean, command=command, env=env_vars, stdout=result)
85+
return Result(label=label, value=mean, command=command, env=env_vars, stdout=result, lower_is_better=self.lower_is_better())
8686

8787
def parse_output(self, output):
8888
csv_file = io.StringIO(output)

scripts/benchmarks/benches/velocity.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def run(self, env_vars) -> Result:
6161

6262
result = self.run_bench(command, env_vars)
6363

64-
return Result(label=self.bench_name, value=self.parse_output(result), command=command, env=env_vars, stdout=result)
64+
return Result(label=self.bench_name, value=self.parse_output(result), command=command, env=env_vars, stdout=result, lower_is_better=self.lower_is_better())
6565

6666
def teardown(self):
6767
return

scripts/benchmarks/output.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def generate_summary_table(chart_data: dict[str, list[Result]]):
116116
if key in results:
117117
value = results[key].value
118118
if key == best_key:
119-
row += f" `**{value}**` |" # Highlight the best value
119+
row += f" <ins>{value}</ins> |" # Highlight the best value
120120
else:
121121
row += f" {value} |"
122122
else:
@@ -132,6 +132,7 @@ def generate_markdown(chart_data: dict[str, list[Result]]):
132132

133133
return f"""
134134
# Summary
135+
<ins>result</ins> is better\n
135136
{summary_table}
136137
# Charts
137138
{mermaid_script}

0 commit comments

Comments
 (0)