Skip to content

Commit e26bba5

Browse files
authored
Merge pull request #2074 from igchor/fix_cts
[CTS] Fix urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest test
2 parents b8b76f4 + 734fe75 commit e26bba5

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

test/conformance/enqueue/enqueue_adapter_level_zero_v2.match

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ urEnqueueKernelLaunchKernelSubGroupTest.Success/Intel_R__oneAPI_Unified_Runtime_
55
urEnqueueKernelLaunchWithVirtualMemory.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}_
66
urEnqueueKernelLaunchUSMLinkedList.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UsePoolEnabled
77
urEnqueueKernelLaunchUSMLinkedList.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UsePoolDisabled
8+
{{OPT}}urEnqueueKernelLaunchIncrementTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UseEventsEnabled
9+
{{OPT}}urEnqueueKernelLaunchIncrementTest.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___UseEventsDisabled
10+
{{OPT}}urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest.Success/UseEventsNoQueuePerThread
11+
{{OPT}}urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest.Success/NoUseEventsNoQueuePerThread
812
urEnqueueMemBufferCopyRectTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___copy_whole_buffer_2D
913
urEnqueueMemBufferCopyRectTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___copy_non_zero_offsets_2D
1014
urEnqueueMemBufferCopyRectTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero___{{.*}}___copy_different_buffer_sizes_2D

test/conformance/enqueue/urEnqueueKernelLaunchAndMemcpyInOrder.cpp

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ TEST_P(urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest, Success) {
343343
constexpr size_t n_dimensions = 1;
344344

345345
auto queue = queuePerThread ? queues[i] : queues.back();
346-
auto kernel = queuePerThread ? kernels[i] : kernels.back();
347-
auto sharedPtr = queuePerThread ? SharedMem[i] : SharedMem.back();
346+
auto kernel = kernels[i];
347+
auto sharedPtr = SharedMem[i];
348348

349349
std::vector<uur::raii::Event> Events(numOpsPerThread + 1);
350350
for (size_t j = 0; j < numOpsPerThread; j++) {
@@ -381,29 +381,12 @@ TEST_P(urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest, Success) {
381381
size_t ExpectedValue = InitialValue;
382382
ExpectedValue += numOpsPerThread;
383383
for (uint32_t j = 0; j < ArraySize; ++j) {
384-
if (queuePerThread) {
385-
ASSERT_EQ(data[j], ExpectedValue);
386-
} else {
387-
// All threads write to the same memory, so the value might be greater
388-
ASSERT_GE(data[j], ExpectedValue);
389-
}
384+
ASSERT_EQ(data[j], ExpectedValue);
390385
}
391386
});
392387
}
393388

394389
for (auto &thread : threads) {
395390
thread.join();
396391
}
397-
398-
if (!queuePerThread) {
399-
size_t ExpectedValue = InitialValue;
400-
ExpectedValue += numOpsPerThread * numThreads;
401-
402-
for (size_t i = 0; i < devices.size(); i++) {
403-
for (uint32_t j = 0; j < ArraySize; ++j) {
404-
ASSERT_EQ(reinterpret_cast<uint32_t *>(SharedMem.back())[j],
405-
ExpectedValue);
406-
}
407-
}
408-
}
409392
}

0 commit comments

Comments
 (0)