Improve applyDiffs to handle failures robustly #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
zongkelong
pushed a commit
to zongkelong/coolook
that referenced
this pull request
Mar 24, 2025
…slation_zh * 'main' of https://github.com/onlook-dev/onlook: Improve applyDiffs to handle failures robustly (onlook-dev#1663) Publish version v0.2.20 (onlook-dev#1662) Add Korean language translation file (onlook-dev#1657) Publish version v0.2.19 (onlook-dev#1659) Check port before starting project (onlook-dev#1661) More persistent port checking (onlook-dev#1660) Handle rate limited (onlook-dev#1658)
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
* Improve applyDiffs to handle failures robustly * Handle failing to apply code change --------- Co-authored-by: Kiet Ho <[email protected]>
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
* Improve applyDiffs to handle failures robustly * Handle failing to apply code change --------- Co-authored-by: Kiet Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the applyDiffs method to make it more robust when applying diffs fails, particularly when search patterns don't match anything in the text.
Link to Devin run: https://app.devin.ai/sessions/3d3c161875884bd8aae0b84fc385bc71
Requested by: [email protected]