Skip to content

Remove selecting first element #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Remove selecting first element #1731

merged 1 commit into from
Apr 4, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Apr 4, 2025

Description

Since this is no longer needed, it's doing more harm than good.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Remove selectFirstElement function and its invocation in Frame.tsx, no longer selecting the first element for WebviewState.DOM_ONLOOK_ENABLED.

  • Behavior:
    • Removes selectFirstElement function and its invocation in Frame.tsx.
    • No longer selects the first element when state === WebviewState.DOM_ONLOOK_ENABLED.

This description was created by Ellipsis for 4f1ba0a. It will automatically update as commits are pushed.

@Kitenite Kitenite merged commit e373840 into main Apr 4, 2025
@Kitenite Kitenite deleted the bugs/select-first branch April 4, 2025 19:23
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4f1ba0a in 44 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. apps/studio/src/routes/editor/WebviewArea/Frame.tsx:97
  • Draft comment:
    Removal of the setTimeout call and function selectFirstElement appears correct since it's no longer needed. Ensure this change aligns with onboarding/documentation requirements.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. apps/studio/src/routes/editor/WebviewArea/Frame.tsx:97
  • Draft comment:
    Removed block that calls selectFirstElement and the function itself. The removal looks safe given the intended change.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. apps/studio/src/routes/editor/WebviewArea/Frame.tsx:97
  • Draft comment:
    PR title and issue reference mention onboarding docs, but the change only removes element selection. Please clarify or update the PR description to match the actual changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment asks the PR author to update the PR description, which is against the rules. It also asks for clarification, which is not allowed. The comment does not provide a specific code suggestion or ask for a test to be written.

Workflow ID: wflow_CLZvDWrgCVAQlyiE


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant