Skip to content

v2.0.x: Open BSD 6.0 and patcher problems #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hppritcha opened this issue Sep 2, 2016 · 8 comments
Closed

v2.0.x: Open BSD 6.0 and patcher problems #2049

hppritcha opened this issue Sep 2, 2016 · 8 comments
Assignees
Milestone

Comments

@hppritcha
Copy link
Member

hppritcha commented Sep 2, 2016

As reported by Paul H., Open BSD 6.0 disallows the patcher code's mprotect call.

See https://mail-archive.com/[email protected]/msg19527.html

This impacts master and v2.x

@hppritcha hppritcha added the bug label Sep 2, 2016
@hppritcha hppritcha added this to the v2.0.2 milestone Sep 2, 2016
@PHHargrove
Copy link
Member

PHHargrove commented Sep 6, 2016

FYI:

I have confirmed w/ the released 2.0.1 tarball that configuring with --enable-mca-no-build=patcher is sufficient to avoid the problem, such that I can pass make check and run ring_c, on both i386 and amd64 systems running OpenBSD-6.0

I suggest that a possible solution is to have the configure probe for the patcher framework attempt an mprotect() call with prot = PROT_EXEC|PROT_READ|PROT_WRITE. Then the problematic code would be automatically disqualified not only on OpenBSD-6, but also on any future OSes (including Linux and Mac OS X) with strong "W^X" policies.

-Paul

@jsquyres
Copy link
Member

jsquyres commented Sep 6, 2016

Per the call today, @artpol84 is going to check to see if Mellanox cares about Open BSD.

@hppritcha
Copy link
Member Author

Mellanox does not care about Open BSD - per discussion devel telecon

@jsquyres
Copy link
Member

@hjelmn Will add some kind of disabling for the patcher on Open BSF 6.0 systems.

@jsquyres jsquyres changed the title Open BSD 6.0 and patcher problems v2.0.x: Open BSD 6.0 and patcher problems Sep 22, 2016
@jsquyres
Copy link
Member

@hjelmn says he can work on this next week.

@hppritcha
Copy link
Member Author

we'd like this fixed in 2.0.2 but not a blocker.

@jsquyres jsquyres modified the milestones: v2.0.2, v2.0.3 Oct 25, 2016
@PHHargrove
Copy link
Member

Current (2.0.2rc3) it is not possible to run on OpenBSD-6 unless one configures with --enable-mca-no-build=patcher.
Would it be appropriate to document this in README for v2.0.2?

@hppritcha
Copy link
Member Author

done, PR #2687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants