All userAuth tests pass

Author: atvanek

__tests__/userAuth.test.ts

@@ -5,15 +5,21 @@ import request from 'supertest';
 import app from '../server/server';
 import mockObj from '../mockData';
 const user = mockObj.user;
+import { sessionIsCreated } from '../app/src/helperFunctions/auth';
 
 //for creating unqiue login credentials
 const num = Math.floor(Math.random() * 1000);
+let username;
+let password;
+let isFbOauth;
 
 describe('User authentication tests', () => {
   //test connection to server
-  test('initial connection test', async () => {
-    const response = await request(app).get('/test');
-    expect(response.text).toEqual('test request is working');
+  describe('initial connection test', () => {
+    it('should connect to the server', async () => {
+      const response = await request(app).get('/test');
+      expect(response.text).toEqual('test request is working');
+    });
   });
   //navigating to signup page should serve
   describe('/', () => {
@@ -83,6 +89,64 @@ describe('User authentication tests', () => {
       });
     });
   });
+
+  describe('sessionIsCreated', () => {
+    it("returns the message 'No Username Input' when no username is entered", () => {
+      return request(app)
+        .post('/login')
+        .send({
+          username: '',
+          password: 'Reactype123!@#',
+          isFbOauth: false
+        })
+        .then((res) => expect(res.text).toBe('"No Username Input"'));
+    });
+
+    it("returns the message 'No Password Input' when no password is entered", () => {
+      return request(app)
+        .post('/login')
+        .send({
+          username: 'reactype123',
+          password: '',
+          isFbOauth: false
+        })
+        .then((res) => expect(res.text).toBe('"No Password Input"'));
+    });
+
+    it("returns the message 'Invalid Username' when username does not exist", () => {
+      return request(app)
+        .post('/login')
+        .send({
+          username: 'l!b',
+          password: 'test',
+          isFbOauth: false
+        })
+        .then((res) => expect(res.text).toBe('"Invalid Username"'));
+    });
+  });
+
+  it("returns the message 'Incorrect Password' when password does not match", () => {
+    return request(app)
+      .post('/login')
+      .send({
+        username: 'test',
+        password: 'test',
+        isFbOauth: false
+      })
+      .then((res) => expect(res.text).toBe('"Incorrect Password"'));
+  });
+  // note that the username and password in this test are kept in the heroku database
+  // DO NOT CHANGE unless you have access to the heroku database
+  it("returns the message 'Success' when the user passes all auth checks", () => {
+    return request(app)
+      .post('/login')
+      .send({
+        username: 'test',
+        password: 'password1!',
+        isFbOauth: false
+      })
+      .then((res) => expect(res.body).toHaveProperty('sessionId'));
+  });
 });
 
 // // // OAuth tests (currently inoperative)

__tests__/users.test.ts renamed to __tests__/usersAuth.test.ts

@@ -15,7 +15,7 @@ export const sessionIsCreated = (
     password,
     isFbOauth
   });
-  const result = fetch(`${serverURL}/login`, {
+  const result = fetch(`/login`, {
     method: 'POST',
     credentials: 'include',
     headers: {
@@ -47,7 +47,7 @@ export const newUserIsCreated = (
     email,
     password
   });
-  const result = fetch(`${serverURL}/signup`, {
+  const result = fetch(`/signup`, {
     method: 'POST',
     credentials: 'include',
     headers: {

app/src/helperFunctions/auth.ts

@@ -41,7 +41,6 @@ const userController: UserController = {
   createUser: (req, res, next) => {
     let email, username, password;
     // use this condition for Oauth login
-    console.log('this is the test body', req.body);
     if (res.locals.signUpType === 'oauth') {
       email = res.locals.githubEmail;
       username = email;
@@ -90,7 +89,6 @@ const userController: UserController = {
         }
         // if no error found when creating a new user, send back user ID in res.locals
         res.locals.id = newUser.id;
-        console.log('no error in test');
         return next();
       }
     );