Skip to content

Commit 66252d6

Browse files
committed
Merge branch 'noah/feature' of https://github.com/oslabs-beta/ReacType-Beta into feature/kevinnoah
2 parents 824d95d + 2559927 commit 66252d6

File tree

15 files changed

+12266
-6584
lines changed

15 files changed

+12266
-6584
lines changed

Dockerfile

Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,64 @@
11
# Stage 1: Build
2-
FROM node:21.2.0-alpine as build
2+
FROM node:21.2.0-alpine AS build
33

44
# python: required dependency for node alpine, shrinks image size from 2.17GB to 1.67GB
55
RUN apk add --no-cache --virtual .gyp \
66
python3 \
77
make \
88
g++
99

10+
RUN npm install -g [email protected]
11+
12+
1013
WORKDIR /app
1114

1215
COPY package*.json ./
1316

17+
1418
RUN npm install --no-install-recommends --fetch-retry-maxtimeout 500000
1519

20+
# install vite virst
21+
22+
1623
COPY . .
24+
ENV NODE_ENV='production'
25+
# i am hoping the above will make it so that the frontend files will know that it is production.
26+
RUN npm run prod-build
1727

1828
# Stage 2: Runtime
19-
FROM node:21.2.0-alpine as runtime
29+
FROM node:21.2.0-alpine AS runtime
2030

2131
WORKDIR /app
2232

2333
COPY --from=build /app/package*.json ./
2434

25-
RUN npm install --no-install-recommends --only=production --fetch-retry-maxtimeout 500000
35+
RUN npm install --no-install-recommends --fetch-retry-maxtimeout 500000
36+
37+
# RUN npm run dev-frontend # no, dont just run the app while building
38+
39+
# make a build file?
2640

41+
42+
# --only=prod
2743
# COPY --from=build /app/.env .env
2844
COPY --from=build /app/config.js ./config.js
2945
COPY --from=build /app/server ./server
30-
COPY --from=build /app/build /app
46+
COPY --from=build /app/build /app/build
47+
48+
COPY .env .env
49+
#just make the env file go into the docker image?
50+
3151

3252
EXPOSE 5656
3353

34-
ENV IS_DOCKER true
54+
ENV IS_DOCKER=true
55+
56+
57+
ENV VIDEOSDK='vidsdk'
58+
59+
# productino you dolt!, if we are using docker, its production!
60+
ENV PORT=5656
61+
62+
# no longer put the envs here cause we are not dumb.
3563

36-
CMD [ "npm", "start" ]
64+
CMD [ "npm", "start" ]

__tests__/componentBuilder.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ describe('componentBuilder', () => {
124124
name: 'p',
125125
childId: 4,
126126
style: {},
127-
attributes: { compText: 'Hello, world!' },
127+
attributes: { comptext: 'Hello, world!' },
128128
events: {},
129129
stateProps: [],
130130
passedInProps: [],

app/src/components/App.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { toggleLoggedIn } from '../redux/reducers/slice/appStateSlice';
66
import { useDispatch } from 'react-redux';
77

88
import AppContainer from '../containers/AppContainer';
9-
109
/**
1110
* The `App` component is the root component of the React application. It performs an initial check
1211
* to determine if a user is logged in (not a 'guest') by inspecting local storage, and updates the

app/src/components/right/ExportButton.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ import createModal from './createModal';
1111
import { RootState } from '../../redux/store';
1212
import zipFiles from '../../helperFunctions/zipFiles';
1313

14+
// NOTE: from the v22 team, this file is unused, if you are editing this and nothing is changing.
15+
// dont say I did not warn you.
16+
1417
/**
1518
* Renders an export button that triggers a modal for selecting export options.
1619
* The button and modal allow users to export project components in various formats.

0 commit comments

Comments
 (0)