Skip to content

Commit 76bb3e8

Browse files
authored
Merge pull request #13 from ReacType-2-0/child-component-fix-2
Reintroduce check for circular references in LeftColExpansionPanel
2 parents 0ebd8d2 + cd3c07d commit 76bb3e8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/components/LeftColExpansionPanel.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@ type Props = {
1515
components: ComponentState[];
1616
deleteComponent: any;
1717
isFocusChild: boolean;
18+
checkChild: boolean;
1819
};
1920

2021
class LeftColExpansionPanel extends Component<Props> {
2122
render() {
22-
const { classes, component, addChild, deleteChild, toggleExpansionPanel, updateComponent, components, deleteComponent, isFocusChild } = this.props;
23+
const { classes, component, addChild, deleteChild, toggleExpansionPanel, updateComponent, components, deleteComponent, isFocusChild, checkChild } = this.props;
2324
const { title, id, color, expanded, stateful } = component;
2425
const addOrRemoveChildButton = () => {
25-
if (expanded || components.every((comp) => !comp.expanded)) {
26+
if (expanded || checkChild || components.every((comp) => !comp.expanded)) {
2627
return <div></div>;
2728
}
2829
if (!isFocusChild) {

src/containers/LeftContainer.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ class LeftContainer extends Component<Props, State> {
207207
addChild={addChild}
208208
deleteChild={deleteChild}
209209
isFocusChild={!isEmpty(focusComponent) && focusComponent.children.some((child) => child.childComponentId === component.id)}
210+
checkChild={component.children.some((child) => child.childComponentId === focusComponent.id)}
210211
changeFocusComponent={changeFocusComponent}
211212
changeFocusChild={changeFocusChild}
212213
deleteComponent={deleteComponent}

0 commit comments

Comments
 (0)