Skip to content

Commit 830063a

Browse files
committed
add credit and make build to the build filder in dockerfile
1 parent 4e29bb2 commit 830063a

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

Dockerfile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,19 @@ COPY --from=build /app/package*.json ./
3131

3232
RUN npm install --no-install-recommends --fetch-retry-maxtimeout 500000
3333

34+
# RUN npm run dev-frontend # no, dont just run the app while building
35+
3436
# make a build file?
3537

38+
3639
# --only=prod
3740
# COPY --from=build /app/.env .env
3841
COPY --from=build /app/config.js ./config.js
3942
COPY --from=build /app/server ./server
40-
COPY --from=build /app/build /app
43+
COPY --from=build /app/build /app/build
44+
45+
46+
4147

4248
EXPOSE 5656
4349

@@ -47,6 +53,7 @@ ENV IS_DOCKER=true
4753
ENV VIDEOSDK='vidsdk'
4854
ENV NODE_ENV='development'
4955
ENV DEV_PORT=5656
56+
ENV PORT=5656
5057

5158
ENV MONGO_DB='mongodb+srv://NOAH:[email protected]/?retryWrites=true&w=majority&appName=TrialCluster'
5259
ENV GITHUB_CLIENT='github client'

server/server.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,9 @@ app.use((err, req, res, next) => {
603603
return res.status(errorObj.status).json(errorObj);
604604
});
605605

606-
app.use('/*', (req, res) => res.status(404).send('Page not found'));
606+
app.use('/*', (req, res) =>
607+
res.status(404).send('You got a 404, thats an error.')
608+
);
607609

608610
// starts server on PORT
609611
if (!isTest) {

0 commit comments

Comments
 (0)