github oauth implementation

Author: andrewjcho84

app/electron/main.js

@@ -326,7 +326,7 @@ ipcMain.on('choose_app_dir', event => {
 // for github oauth login in production, since cookies are not accessible through document.cookie on local filesystem, we need electron to grab the cookie that is set from oauth, this listens for an set cookie event from the renderer process then sends back the cookie
 ipcMain.on('set_cookie', event => {
   session.defaultSession.cookies
-    .get({ url: 'https://reactype.heroku.com' })
+    .get({ url: 'https://reactype.herokuapp.com' })
     .then(cookie => {
       console.log(cookie);
       event.reply('give_cookie', cookie);
@@ -339,12 +339,9 @@ ipcMain.on('set_cookie', event => {
 // again for production, document.cookie is not accessible so we need this listener on main to delete the cookie on logout
 ipcMain.on('delete_cookie', event => {
   session.defaultSession.cookies
-    .remove('https://reactype.heroku.com', 'ssid')
+    .remove('https://reactype.herokuapp.com', 'ssid')
     .then(removed => {
       console.log('Cookies deleted', removed);
     })
     .catch(err => console.log('Error deleting cookie:', err));
 });
-
-// bypass ssl certification validation error
-// app.commandLine.appendSwitch('ignore-certificate-errors', 'true');

app/electron/preload.js

@@ -11,7 +11,7 @@ const {
   setCookie,
   getCookie,
   delCookie,
-  reload
+  github
 } = require('./preloadFunctions/cookies');
 
 // Expose protected methods that allow the renderer process to use select node methods
@@ -33,5 +33,6 @@ contextBridge.exposeInMainWorld('api', {
   writeFile,
   setCookie,
   getCookie,
-  delCookie
+  delCookie,
+  github
 });

app/electron/preloadFunctions/cookies.js

@@ -14,4 +14,8 @@ const delCookie = () => {
   return ipcRenderer.send('delete_cookie');
 };
 
-module.exports = { setCookie, getCookie, delCookie };
+const github = () => {
+  return ipcRenderer.send('github');
+};
+
+module.exports = { setCookie, getCookie, delCookie, github };

app/src/components/login/SignIn.tsx

@@ -80,6 +80,19 @@ const SignIn: React.FC<LoginInt & RouteComponentProps> = props => {
   const [invalidUser, setInvalidUser] = useState(false);
   const [invalidPass, setInvalidPass] = useState(false);
 
+  useEffect(() => {
+    setInterval(() => {
+      window.api.setCookie();
+      window.api.getCookie(cookie => {
+        if (cookie[0]) {
+          window.localStorage.setItem('ssid', cookie[0].value);
+          props.history.push('/');
+          clearInterval();
+        }
+      });
+    }, 2000);
+  }, []);
+
   const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     let inputVal = e.target.value;
     switch (e.target.name) {
@@ -203,25 +216,18 @@ const SignIn: React.FC<LoginInt & RouteComponentProps> = props => {
           Sign In
         </Button>
         {/* Hiding github oauth button as it's still buggy and not fully working */}
-        {/* <Button
+        <Button
           fullWidth
           variant="contained"
           color="default"
           className={classes.submit}
-          href="https://reactype.heroku.com/github"
           onClick={() => {
             console.log('Inside onclick of github');
-            setTimeout(() => {
-              window.api.setCookie();
-              window.api.getCookie(cookie => {
-                window.localStorage.setItem('ssid', cookie[0].value);
-                props.history.push('/');
-              });
-            }, 2000);
+            window.api.github();
           }}
         >
           <GitHubIcon />
-        </Button> */}
+        </Button>
 
         <Button
           fullWidth