Skip to content

version.h is missing in release packet #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eigen2017 opened this issue Nov 11, 2019 · 3 comments
Closed

version.h is missing in release packet #1094

eigen2017 opened this issue Nov 11, 2019 · 3 comments

Comments

@eigen2017
Copy link

https://github.com/open-source-parsers/jsoncpp/archive/1.9.1.tar.gz

newest release don't have version.h file
@cdunn2001
Copy link
Contributor

Doesn't running cmake or meson generate the version.h file for the given version?

@cdunn2001
Copy link
Contributor

https://github.com/open-source-parsers/jsoncpp/wiki/Building

@dota17
Copy link
Member

dota17 commented Apr 28, 2020 •
edited
Loading

@eigen2017 Thanks for reporting. the release package 1.9.1.zip and 1.9.1.tar.gz are indeed missing head file version.h, this is a small operational error

EDIT: this is not a mistake, the reason is that we changed the version strategy after we release the 1.9.1, it was introduced in #989.

@dota17 dota17 closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdunn2001 @eigen2017 @dota17