Skip to content

CMake configuration needs some improvements #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirmasoudabdol opened this issue Nov 25, 2021 · 1 comment
Open

CMake configuration needs some improvements #1358

amirmasoudabdol opened this issue Nov 25, 2021 · 1 comment

Comments

@amirmasoudabdol
Copy link

amirmasoudabdol commented Nov 25, 2021

Describe the bug

Here is a full description, cpm-cmake/CPM.cmake#299.

To Reproduce

  1. Build the problem with a CMake
  2. CMake build and install the project at the same time.

Expected behavior

In modern CMake, build and install targets are not the same, and by mixing them into one step, you are causing issues for other projects that wants to include the jsoncpp as dependency to their projects. Because jsoncpp initiate the install stage, all other projects will get confused and initiate their install stages into the GNU paths, and that should not happen unless intentionally. I was expecting that this flag, JSONCPP_WITH_CMAKE_PACKAGE would allow me to separate this but it doesn't.

Desktop (please complete the following information):

  • OS: macOS Monterey 12.0
  • CMake version, 3.21

Additional context

It is ok that this is a default behaviour but maybe there should be an option to disable it?

@Andres6936
Copy link

See #1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants