Skip to content

CMake: remove ccache babysitting #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SpaceIm opened this issue Nov 23, 2022 · 0 comments · Fixed by #1448
Closed

CMake: remove ccache babysitting #1447

SpaceIm opened this issue Nov 23, 2022 · 0 comments · Fixed by #1448

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 23, 2022

Is your feature request related to a problem? Please describe.
Currently jsoncpp unconditionally tries to use ccache if found on system, so build may not be reproducible depending on build machine configuration, or even fails due to local cache corruption in ccache.

Describe the solution you'd like
Completely remove ccache micro-management in CMakeLists since it's not a usage requirement of jsoncpp. There is a canonical way to enable ccache usage: set CMAKE_C_COMPILER_LAUNCHER & CMAKE_CXX_COMPILER_LAUNCHER externally, so that users have full control over ccache usage, regardless of what is installed on their system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant