binary-compatibility w/ old 0.6.x

[cdunn2001]

See #147 for some discussion.

[cdunn2001]

Release 0.8.0-rc3 (like 0.8.0-rc.1)is binary-compatible. @cinemast, could you try it? You might find some missing symbols, but only private ones, not part of the public API. I have been very careful with diffing, and I have double-checked by compiling test_lib_json for 0.6.0-rc2 and linking 0.8.0 at runtime.

[cinemast]

I am starting to double check now. First thing I can see that SONAME is version 1, it should be 0. And also the .so file is called libjsoncpp.so.1.4.0 which should be libjsoncpp.so.0.8.0

[cinemast]

https://gist.github.com/anonymous/58ade892c88aac6805e4

[cdunn2001]

Are you on master? The v0.8.0 branch is at version 0.8.0. I don't see how you could possibly get 1.4.0 on that branch... Yeah, that string does not exist.

You can look at the 0.8.0-rc.3 release, or just pull the v0.8.0 branch.

[cinemast]

I took the release from here: https://github.com/open-source-parsers/jsoncpp/releases/tag/0.8.0-rc1. Sorry apparently I picked the wrong one.

[cdunn2001]

Bad release. Deleted. Use 0.8.0-rc3.

[cinemast]

https://gist.github.com/cinemast/080cddbb54a19e8fb043

Are the classes containing incompatibilities private? I guess you can tell more easily than me.

[cdunn2001]

Do you have any idea which commit Debian was using? Probably just a download from sourceforge, huh?

I have to examine these:

json_writer.cpp, libjson_linux-gcc-4.9.1_libmt.so
namespace Json
StyledWriter::normalizeEOL ( std::string const&const text ) [static] 

reader.h, libjson_linux-gcc-4.9.1_libmt.so
namespace Json
Reader::expectToken ( enum Reader::TokenType type, Reader::Token&const token, char const* message ) 

value.h, libjson_linux-gcc-4.9.1_libmt.so
namespace Json
Value::CommentInfo::setComment ( char const* text ) 
Value::null [data] 

writer.h, libjson_linux-gcc-4.9.1_libmt.so
namespace Json
StyledStreamWriter::normalizeEOL ( std::string const&const text ) [static] 

and fix these:

StyledStreamWriter:
Size of field addChildValues_ has been changed from 1 byte to 1 bit.
Field indented_ has been added to this type.

[cinemast]

http://ftp.de.debian.org/debian/pool/main/libj/libjsoncpp/libjsoncpp_0.6.0~rc2.orig.tar.gz

I guess it is still from SF yes.

[cdunn2001]

• normalizeEOL: private
• expectToken: private
• CommentInfo::setComment: private

And all non-virtual, which is good.

StyledStreamWriter:

• addChildValues_ and indented_ are private.
• sizeof(StyledStreamWriter) has not changed

So it looks good to me.

[cinemast]

Great! Thank you for providing this. It would be great if the pending security fix for #88 would make it to 0.8.x release.

[cdunn2001]

Yes, definitely. Probably tomorrow.

Also, by storing a Json::Value in the new CharReader and StreamWriter, we can easily add features without breaking binary-compatibility.

[cdunn2001]

@cinemast, Sorry. You should use 0.9.z, or at least 0.8.4. It turns out that Json::Value::null had not been defined in earlier releases, after 0.6.0. That oversight affects only people who used that symbol directly, which is probably nobody, but for correctness the more recent versions are better.

Besides, 0.9.z (and 1.5.z) have proper UTF-8 support for embedded nulls, for anyone willing to avoid c-strings.

[cinemast]

ahhh.. that is bad news. Alright I will repackage for unstable.

[cdunn2001]

To be clear, it would not affect compilation. The symbol was declared but not defined.

[cinemast]

I know, i know. Compilation is not the issue here, it is the exported ABI symbols that change. How fast will you continue releasing new versions? Should I wait for a next stable release?

[cdunn2001]

I back-ported this change to 0.8.4, if you want. I consider 0.9.0 well-tested, with important fixes, but it's up to you.

[cdunn2001]

Btw, I don't expect any more big changes to this project. UTF-8 is important, but not much else will happen until 2.0, which will be completely C++11.

[cinemast]

Great. I will package 0.9.0 then for debian. Thank you for keeping this project alive.

[cdunn2001]

Please package 0.9.4. Although the 0.9.0 version worked, it did not properly support zeroes in UTF-8 as advertised. I wrote the tests wrong. Quite a blunder. Sorry again.

[cinemast]

I'll wait a week or two. I am sure you will understand why :)

[cdunn2001]

You were right. 0.10.0 is good. It's important to use that instead of 0.8.z or 0.9.z.

[cinemast]

Haha yes I followed the conversation about missing virtual dtor. No problem. My sponsor at debian is currently not responsive anyway.

[cdunn2001]

I really wish Macosx had valgrind. What would you suggest as an alternative? Or should I just set up a Linux VM?

[cinemast]

Well I integrated the valgrind checking to my travis build. Maybe that is a solution for you:

https://github.com/cinemast/libjson-rpc-cpp/blob/master/.travis.yml

[cdunn2001]

Great idea! Thx.