Fixes for embedding requirements install #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed sklearn is in the install which is deprecated and scikit-learn is already in there as well, and scipy was missing.
hallacy
approved these changes
Mar 1, 2023
|
Awesome! |
15 tasks
Kyle-Verhoog
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Apr 27, 2023
Old versions of `openai-python` use deprecated `sklearn` instead of `scikit-learn` (fixed here openai/openai-python#227). In order to install `sklearn` in our CI venvs, we need to add an environment variable. ``` × python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [18 lines of output] The 'sklearn' PyPI package is deprecated, use 'scikit-learn' rather than 'sklearn' for pip commands. Here is how to fix this error in the main use cases: - use 'pip install scikit-learn' rather than 'pip install sklearn' - replace 'sklearn' by 'scikit-learn' in your pip requirements files (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...) - if the 'sklearn' package is used by one of your dependencies, it would be great if you take some time to track which package uses 'sklearn' instead of 'scikit-learn' and report it to their issue tracker - as a last resort, set the environment variable SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error More information is available at https://github.com/scikit-learn/sklearn-pypi-package If the previous advice does not cover your use case, feel free to report it at https://github.com/scikit-learn/sklearn-pypi-package/issues/new [end of output] ```
Kyle-Verhoog
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Apr 27, 2023
Old versions of `openai-python` use deprecated `sklearn` instead of `scikit-learn` (fixed here openai/openai-python#227). In order to install `sklearn` in our CI venvs, we need to add an environment variable. ``` × python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [18 lines of output] The 'sklearn' PyPI package is deprecated, use 'scikit-learn' rather than 'sklearn' for pip commands. Here is how to fix this error in the main use cases: - use 'pip install scikit-learn' rather than 'pip install sklearn' - replace 'sklearn' by 'scikit-learn' in your pip requirements files (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...) - if the 'sklearn' package is used by one of your dependencies, it would be great if you take some time to track which package uses 'sklearn' instead of 'scikit-learn' and report it to their issue tracker - as a last resort, set the environment variable SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error More information is available at https://github.com/scikit-learn/sklearn-pypi-package If the previous advice does not cover your use case, feel free to report it at https://github.com/scikit-learn/sklearn-pypi-package/issues/new [end of output] ```
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
I noticed sklearn is in the install which is deprecated and scikit-learn is already in there as well, and scipy was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed sklearn is in the install which is deprecated and scikit-learn is already in there as well, and scipy was missing.
This fixes #210