Skip to content

Update setup.py #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Update setup.py #99

merged 3 commits into from
Jun 27, 2022

Conversation

oscar-king
Copy link
Contributor

Add missing dependency scikit-learn

Add missing dependency scikit-learn
Versioning issue fix
@hallacy
Copy link
Collaborator

hallacy commented Jun 23, 2022

hey @oscar-king, thanks for the PR!

I generally agree with this approach though I worry that these extra dependencies add a lot of extra requirements to the package that are only really needed if you're using the embeddings notebooks. How about something more like:

    extras_require={
        "dev": ["black~=21.6b0", "pytest==6.*"],
        "embeddings": [
           <extra requirements go in this target> 
        ],
    },

And maybe change the pins to greater than or just don't pin them

@hallacy hallacy merged commit 8f8f791 into openai:main Jun 27, 2022
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* Update setup.py

Add missing dependency scikit-learn

* Update setup.py

Versioning issue fix

* Added requirements into extras_require
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
use @function_tool decorator in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants