fix(schema-object): transform toplevel schema object #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 772090f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LucaSchwan
force-pushed
the
fix/schema-object/transform-toplevel-schema
branch
2 times, most recently
from
11826f1 to
af02ae1
Compare
|
Thanks so much! At a glance this seems correct, but if you could rebase from the latest |
LucaSchwan
force-pushed
the
fix/schema-object/transform-toplevel-schema
branch
2 times, most recently
from
5b02bb8 to
2cb5ff8
Compare
|
I rebased. There was some error in the ci before, I'll look into that when the workflow ran again on the rebased code. |
LucaSchwan
force-pushed
the
fix/schema-object/transform-toplevel-schema
branch
from
2cb5ff8 to
772090f
Compare
|
I just had the API of the |
drwpow
approved these changes
Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #1619
How to Review
I'm not sure if this is the right place to call the transform yet. So please give me some feedback on wether it is ok there or if it should go somewhere else. I've
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)