fix: escape quotes in enum string values #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g values are not escaped
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 5 5
Lines 268 268
Branches 90 90
=======================================
Hits 249 249
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
drwpow
reviewed
Nov 12, 2020
| @@ -73,7 +73,7 @@ export default function generateTypesV3( | |||
| (node.enum as string[]).map((item) => | |||
| typeof item === "number" || typeof item === "boolean" | |||
| ? item | |||
| : `'${item}'` | |||
| : `'${item.replace(/'/g, "\\'")}'` | |||
There was a problem hiding this comment.
This makes sense to me. In my experience, you should never be too aggressive escaping quotes like this, as you may end up with more things escaped than anticipated.
drwpow
approved these changes
Nov 12, 2020
|
I believe this fixes #256? |
ah yes, thanks! |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into this problem when updating to the latest GitHub schema, this PR reproduces the problem the same way. I'm looking into fixing it
fixes #256