Skip to content

Correcting Readme Example #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Correcting Readme Example #424

merged 1 commit into from
Dec 31, 2020

Conversation

th-m
Copy link
Contributor

@th-m th-m commented Dec 30, 2020

you need the .default

you need the `.default`
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #424 (c019277) into main (fc40e78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files           5        5           
  Lines         264      264           
  Branches       86       86           
=======================================
  Hits          247      247           
  Misses         13       13           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ef7f6...c019277. Read the comment docs.

@drwpow
Copy link
Contributor

drwpow commented Dec 31, 2020

Great catch! Thank you.

@drwpow drwpow merged commit 8f81611 into openapi-ts:main Dec 31, 2020
@drwpow
Copy link
Contributor

drwpow commented Dec 31, 2020

@all-contributors please add @th-m for docs

@allcontributors
Copy link
Contributor

@drwpow

I've put up a pull request to add @th-m! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants