Escape Enums in V2 #425
Merged
Escape Enums in V2 #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 5 5
Lines 264 264
Branches 86 86
=======================================
Hits 247 247
Misses 13 13
Partials 4 4
Continue to review full report at Codecov.
|
drwpow
reviewed
Dec 31, 2020
| @@ -62,7 +62,7 @@ export default function generateTypesV2(input: OpenAPI2 | OpenAPI2Schemas, optio | |||
| case "enum": { | |||
| return tsUnionOf( | |||
| (node.enum as string[]).map((item) => | |||
| typeof item === "number" || typeof item === "boolean" ? item : `'${item}'` | |||
| typeof item === "number" || typeof item === "boolean" ? item : `'${item.replace(/'/g, "\\'")}'` | |||
drwpow
reviewed
Dec 31, 2020
| @@ -226,7 +226,7 @@ describe("transformation", () => { | |||
| expect(swaggerToTS(schema)).toBe( | |||
| format(` | |||
| export interface definitions { | |||
| union: { string?: 'Totoro' | 'Satsuki' | 'Mei' } | |||
| union: { string?: 'Totoro' | 'Sats\\'uki' | 'Mei' } | |||
|
@all-contributors please add @asithade for code, bug |
|
I've put up a pull request to add @asithade! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the same fix on V3 as V2.
Ref: #365